Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1782453004: Fix some issues for Linux Vulkan build (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix some issues for Linux Vulkan build lifecycle in GrVkGpu was tagged as uninitialized before use, and err in GrVkImage as unused. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1782453004 Committed: https://skia.googlesource.com/skia/+/0fcfb7525f60eabfdaf9761c75c7d4fd1b46d0c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 2 chunks +6 lines, -18 lines 0 comments Download
M src/gpu/vk/GrVkImage.cpp View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
4 years, 9 months ago (2016-03-09 14:53:47 UTC) #4
bsalomon
On 2016/03/09 14:53:47, jvanverth1 wrote: lgtm, we must have different compilers, I didn't get these ...
4 years, 9 months ago (2016-03-09 14:57:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782453004/1
4 years, 9 months ago (2016-03-09 16:14:18 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 17:57:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0fcfb7525f60eabfdaf9761c75c7d4fd1b46d0c5

Powered by Google App Engine
This is Rietveld 408576698