Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 1782443008: Change scoped_ptr to a type alias for std::unique_ptr for OS_ANDROID (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
danakj, Yaron, qinmin, Torne
CC:
android-webview-reviews_chromium.org, Alex Vakulenko, avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, gavinp+memory_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change scoped_ptr to a type alias for std::unique_ptr for OS_ANDROID BUG=554298, 579269 R=danakj@chromium.org TBR=qinmin@chromium.org,torne@chromium.org,yfriedman@chromium.org Committed: https://crrev.com/9502adfa9aa5b3f3a7b06bbd23503ced64387df2 Cr-Commit-Position: refs/heads/master@{#380543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M android_webview/native/aw_dev_tools_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/scoped_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_codec_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
dcheng
+danakj for //base +torne for //android_webview +yfriedman for //chrome/browser/android +qinmin for //media/base/android
4 years, 9 months ago (2016-03-10 23:26:19 UTC) #2
danakj
LGTM
4 years, 9 months ago (2016-03-10 23:26:55 UTC) #3
dcheng
TBRing the remaining owners, as the rest of the patch is relatively uninteresting.
4 years, 9 months ago (2016-03-11 01:27:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782443008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782443008/1
4 years, 9 months ago (2016-03-11 01:28:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/138297)
4 years, 9 months ago (2016-03-11 02:46:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782443008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782443008/1
4 years, 9 months ago (2016-03-11 03:21:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 05:40:55 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9502adfa9aa5b3f3a7b06bbd23503ced64387df2 Cr-Commit-Position: refs/heads/master@{#380543}
4 years, 9 months ago (2016-03-11 05:42:59 UTC) #14
Torne
android_webview LGTM
4 years, 9 months ago (2016-03-11 13:47:22 UTC) #15
Yaron
4 years, 9 months ago (2016-03-11 15:59:05 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698