Create LoadProfile method in profile_manager

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 
 #include <stddef.h>
@@ skipping 17 matching lines @@
 #include "content/public/browser/notification_registrar.h"
 
 class NewProfileLauncher;
 class ProfileInfoCache;
 
 class ProfileManager : public base::NonThreadSafe,
                        public content::NotificationObserver,
                        public Profile::Delegate {
  public:
   typedef base::Callback<void(Profile*, Profile::CreateStatus)> CreateCallback;
+  typedef base::Callback<void(Profile*)> ProfileLoadedCallback;
 
   explicit ProfileManager(const base::FilePath& user_data_dir);
   ~ProfileManager() override;
 
 #if defined(ENABLE_SESSION_SERVICE)
   // Invokes SessionServiceFactory::ShutdownForProfile() for all profiles.
   static void ShutdownSessionServices();
 #endif
 
   // Physically remove deleted profile directories from disk.
@@ skipping 32 matching lines @@
   // Because this method might synchronously create a new profile, it should
   // only be called for the initial profile or in tests, where blocking is
   // acceptable.
   // TODO(bauerb): Migrate calls from other code to GetProfileByPath(), then
   // make this method private.
   Profile* GetProfile(const base::FilePath& profile_dir);
 
   // Returns total number of profiles available on this machine.
   size_t GetNumberOfProfiles();
 
+  // Loads an existing profile given it's |profile_name|
+  // The profile is loaded asynchronously and |callback| is executed once it's
+  // loaded
+  // The callback will be executed with a NULL profile if there is an error.
+  // Should be called on the UI thread.

[Peter Beverloo, 2016/03/11 17:45:15]

This should document |incognito| as well, have proper sentences and a few
editorial nits. What about:

  // Asynchronously loads an existing profile given its |profile_name| within
  // the user data directory, optionally in |incognito| mode. The |callback|
  // will be called with the Profile when it has been loaded, or with a nullptr
  // otherwise. Should be called on the UI thread.

[Peter Beverloo, 2016/03/11 17:45:15]

Should we match GetProfile() above and swap out the |profile_name| std::string
with a base::FilePath called |profile_dir|? This would make it easy to have the
same fast-path (GetProfileByPath()) as in that method.

[Miguel Garcia, 2016/03/14 18:29:00]

Done.

[Miguel Garcia, 2016/03/14 18:29:00]

Let's let the owners decide. I am fine swapping it. The difference though is
that in the other methods that is actually the full FilePath whereas here we
want to leave the fact that we are passing the last component of the path as an
implementation detail.

+  void LoadProfile(const std::string& profile_name,
+                   bool incognito,
+                   const ProfileLoadedCallback& callback);
+
   // Explicit asynchronous creation of a profile located at |profile_path|.
   // If the profile has already been created then callback is called
   // immediately. Should be called on the UI thread.
   void CreateProfileAsync(const base::FilePath& profile_path,
                           const CreateCallback& callback,
                           const base::string16& name,
                           const std::string& icon_url,
                           const std::string& supervised_user_id);
 
   // Returns true if the profile pointer is known to point to an existing
@@ skipping 289 matching lines @@
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const base::FilePath& user_data_dir);
 
  protected:
   void DoFinalInitForServices(Profile*, bool) override {}
   void DoFinalInitLogging(Profile*) override {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_