Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1782443002: Ensure appropriate bounds checking for Array subclass concat (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure appropriate bounds checking for Array subclass concat When an Array subclass is used as the receiver for concat, or with certain usages of @@species, the output that's constructed is of a different type with new slow path logic. This slow path still made references to elements, so it's important that bounds checking for a too-long result still be done. This patch repairs that bounds checking. R=cbruni LOG=Y BUG=chromium:592340 Committed: https://crrev.com/ca5deb1ff889cf0ffb48543402f3b930a017aa13 Cr-Commit-Position: refs/heads/master@{#34636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M src/builtins.cc View 2 chunks +8 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-592340.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782443002/1
4 years, 9 months ago (2016-03-09 06:38:05 UTC) #3
Dan Ehrenberg
4 years, 9 months ago (2016-03-09 06:50:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 07:36:35 UTC) #6
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-09 18:39:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782443002/1
4 years, 9 months ago (2016-03-09 18:50:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 18:52:43 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ca5deb1ff889cf0ffb48543402f3b930a017aa13 Cr-Commit-Position: refs/heads/master@{#34636}
4 years, 9 months ago (2016-03-09 18:54:56 UTC) #13
Camillo Bruni
4 years, 9 months ago (2016-03-10 08:31:20 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698