Subzero: 'make presubmit' checks for certain prerequisites.

Subzero: 'make presubmit' checks for certain prerequisites.

A fresh checkout of native_client lacks some components that Subzero's "make -f Makefile.standalone presubmit" needs.

Add explicit checks for these components, and when missing, print suggestions for how to create them.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4359
R=jpp@chromium.org, smklein@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=96fac393ae7c37837773abe282f647cfa5bce33c

[Jim Stichnoth, 2016-03-11 05:08:30]

Description was changed from

==========
Subzero: 'make presubmit' checks for certain prerequisites.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4359
==========

to

==========
Subzero: 'make presubmit' checks for certain prerequisites.

A fresh checkout of native_client lacks some components that Subzero's "make -f
Makefile.standalone presubmit" needs.

Add explicit checks for these components, and when missing, print suggestions
for how to create them.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4359
==========

[Jim Stichnoth, 2016-03-11 05:08:30]

stichnot@chromium.org changed reviewers:
+ mseaborn@chromium.org, phosek@chromium.org, smklein@chromium.org

[Jim Stichnoth, 2016-03-11 05:10:26]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[John, 2016-03-11 16:40:26]

lgtm

https://codereview.chromium.org/1782343003/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/1782343003/diff/40001/Makefile.standalone#new...
Makefile.standalone:543: echo "Consider running 'scons nonsfi_loader'" \
maybe you could auto-build the nonsfi-loader here.

[Sean Klein, 2016-03-11 18:14:25]

LGTM, thank you!

[Jim Stichnoth, 2016-03-11 22:58:08]

https://codereview.chromium.org/1782343003/diff/40001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/1782343003/diff/40001/Makefile.standalone#new...
Makefile.standalone:543: echo "Consider running 'scons nonsfi_loader'" \
On 2016/03/11 16:40:26, John wrote:
> maybe you could auto-build the nonsfi-loader here.

I thought about that, but I'd rather not try to be too smart here.

I don't know if this is still the case, but I remember something where one would
get a clean checkout of native_client, run toolchain_build_pnacl.py, and then
try to run cross tests.  The first time "run.py" is run, it helpfully tries to
build scons targets.  The tests that would run in parallel before the scons
build completes, would fail spuriously.  Subsequent cross test runs would be
fine.

I think it's simpler and safer to have the user take care of it manually.

[Jim Stichnoth, 2016-03-11 22:58:27]

Description was changed from

==========
Subzero: 'make presubmit' checks for certain prerequisites.

A fresh checkout of native_client lacks some components that Subzero's "make -f
Makefile.standalone presubmit" needs.

Add explicit checks for these components, and when missing, print suggestions
for how to create them.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4359
==========

to

==========
Subzero: 'make presubmit' checks for certain prerequisites.

A fresh checkout of native_client lacks some components that Subzero's "make -f
Makefile.standalone presubmit" needs.

Add explicit checks for these components, and when missing, print suggestions
for how to create them.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4359
R=jpp@chromium.org, smklein@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-03-11 22:58:28]

Committed patchset #3 (id:40001) manually as
96fac393ae7c37837773abe282f647cfa5bce33c (presubmit successful).