Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.py

Issue 1782333002: Add bisect config validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/example.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.py b/scripts/slave/recipe_modules/auto_bisect/example.py
index ae9ffc310c3bd884caae6f5819d1616c4c391d40..6b50260d314e66209c832a87a730f559247f5094 100644
--- a/scripts/slave/recipe_modules/auto_bisect/example.py
+++ b/scripts/slave/recipe_modules/auto_bisect/example.py
@@ -73,6 +73,11 @@ def GenTests(api):
basic_test = _make_test(api, _get_basic_test_data(), 'basic')
yield basic_test
+ invalid_config_test = api.test('invalid_config')
+ invalid_config_test += api.properties(
+ bisect_config=_get_config({'good_revision': 'not a valid revision'}))
+ yield invalid_config_test
+
failed_build_test = _make_test(
api, _get_ref_range_only_test_data(), 'failed_build_test',
extra_config={'dummy_builds': None})
@@ -386,8 +391,8 @@ def _get_config(params=None):
'bad_revision': '314017',
'metric': 'mean_input_event_latency/mean_input_event_latency',
'repeat_count': '2',
+ 'bug_id': '-1',
'max_time_minutes': '5',
- 'bug_id': '',
'gs_bucket': 'chrome-perf',
'builder_host': 'master4.golo.chromium.org',
'builder_port': '8341',
@@ -395,7 +400,7 @@ def _get_config(params=None):
'dummy_job_names': 'True',
'bypass_stats_check': 'True',
'skip_gclient_ops': 'True',
- 'recipe_tester_name': 'linux_perf_tester'
+ 'recipe_tester_name': 'linux_perf_tester',
}
if params:
example_config.update(params)

Powered by Google App Engine
This is Rietveld 408576698