Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2077)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json

Issue 1782333002: Add bisect config validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
index 86d483893008c02efe5d6d001a804450b4ac355e..7e1bd2abc86ce179abc6268972c5658df6fd696b 100644
--- a/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
+++ b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
@@ -25,7 +25,7 @@
"~followup_annotations": [
"@@@STEP_LOG_LINE@Bisect job configuration@{@@@",
"@@@STEP_LOG_LINE@Bisect job configuration@ \"bad_revision\": \"314017\", @@@",
- "@@@STEP_LOG_LINE@Bisect job configuration@ \"bug_id\": \"\", @@@",
+ "@@@STEP_LOG_LINE@Bisect job configuration@ \"bug_id\": \"-1\", @@@",
"@@@STEP_LOG_LINE@Bisect job configuration@ \"builder_host\": \"master4.golo.chromium.org\", @@@",
"@@@STEP_LOG_LINE@Bisect job configuration@ \"builder_port\": \"8341\", @@@",
"@@@STEP_LOG_LINE@Bisect job configuration@ \"bypass_stats_check\": \"True\", @@@",
@@ -977,9 +977,9 @@
"Release",
"--xvfb",
"--factory-properties",
- "{\"bisect_config\": {\"bad_revision\": \"314017\", \"bug_id\": \"\", \"builder_host\": \"master4.golo.chromium.org\", \"builder_port\": \"8341\", \"bypass_stats_check\": \"True\", \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", \"dummy_builds\": \"True\", \"dummy_job_names\": \"True\", \"good_revision\": \"314015\", \"gs_bucket\": \"chrome-perf\", \"max_time_minutes\": \"5\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"recipe_tester_name\": \"linux_perf_tester\", \"repeat_count\": \"2\", \"skip_gclient_ops\": \"True\", \"test_type\": \"perf\"}, \"buildername\": \"linux_perf_bisect\", \"mastername\": \"tryserver.chromium.perf\", \"recipe\": \"auto_bisect:example\", \"slavename\": \"dummyslave\"}",
+ "{\"bisect_config\": {\"bad_revision\": \"314017\", \"bug_id\": \"-1\", \"builder_host\": \"master4.golo.chromium.org\", \"builder_port\": \"8341\", \"bypass_stats_check\": \"True\", \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", \"dummy_builds\": \"True\", \"dummy_job_names\": \"True\", \"good_revision\": \"314015\", \"gs_bucket\": \"chrome-perf\", \"max_time_minutes\": \"5\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"recipe_tester_name\": \"linux_perf_tester\", \"repeat_count\": \"2\", \"skip_gclient_ops\": \"True\", \"test_type\": \"perf\"}, \"buildername\": \"linux_perf_bisect\", \"mastername\": \"tryserver.chromium.perf\", \"recipe\": \"auto_bisect:example\", \"slavename\": \"dummyslave\"}",
"--build-properties",
- "{\"bisect_config\": {\"bad_revision\": \"314017\", \"bug_id\": \"\", \"builder_host\": \"master4.golo.chromium.org\", \"builder_port\": \"8341\", \"bypass_stats_check\": \"True\", \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", \"dummy_builds\": \"True\", \"dummy_job_names\": \"True\", \"good_revision\": \"314015\", \"gs_bucket\": \"chrome-perf\", \"max_time_minutes\": \"5\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"recipe_tester_name\": \"linux_perf_tester\", \"repeat_count\": \"2\", \"skip_gclient_ops\": \"True\", \"test_type\": \"perf\"}, \"buildername\": \"linux_perf_bisect\", \"mastername\": \"tryserver.chromium.perf\", \"recipe\": \"auto_bisect:example\", \"slavename\": \"dummyslave\"}",
+ "{\"bisect_config\": {\"bad_revision\": \"314017\", \"bug_id\": \"-1\", \"builder_host\": \"master4.golo.chromium.org\", \"builder_port\": \"8341\", \"bypass_stats_check\": \"True\", \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", \"dummy_builds\": \"True\", \"dummy_job_names\": \"True\", \"good_revision\": \"314015\", \"gs_bucket\": \"chrome-perf\", \"max_time_minutes\": \"5\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"recipe_tester_name\": \"linux_perf_tester\", \"repeat_count\": \"2\", \"skip_gclient_ops\": \"True\", \"test_type\": \"perf\"}, \"buildername\": \"linux_perf_bisect\", \"mastername\": \"tryserver.chromium.perf\", \"recipe\": \"auto_bisect:example\", \"slavename\": \"dummyslave\"}",
"--step-name=Running Bisection",
"--builder-name=linux_perf_bisect",
"--slave-name=dummyslave",
@@ -994,7 +994,7 @@
"--path_to_goma",
"[BUILD]/goma",
"--build-properties",
- "{\"bisect_config\": {\"bad_revision\": \"314017\", \"bug_id\": \"\", \"builder_host\": \"master4.golo.chromium.org\", \"builder_port\": \"8341\", \"bypass_stats_check\": \"True\", \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", \"dummy_builds\": \"True\", \"dummy_job_names\": \"True\", \"good_revision\": \"314015\", \"gs_bucket\": \"chrome-perf\", \"max_time_minutes\": \"5\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"recipe_tester_name\": \"linux_perf_tester\", \"repeat_count\": \"2\", \"skip_gclient_ops\": \"True\", \"test_type\": \"perf\"}, \"buildername\": \"linux_perf_bisect\", \"mastername\": \"tryserver.chromium.perf\", \"recipe\": \"auto_bisect:example\", \"slavename\": \"dummyslave\"}"
+ "{\"bisect_config\": {\"bad_revision\": \"314017\", \"bug_id\": \"-1\", \"builder_host\": \"master4.golo.chromium.org\", \"builder_port\": \"8341\", \"bypass_stats_check\": \"True\", \"command\": \"src/tools/perf/run_benchmark -v --browser=release smoothness.tough_scrolling_cases\", \"dummy_builds\": \"True\", \"dummy_job_names\": \"True\", \"good_revision\": \"314015\", \"gs_bucket\": \"chrome-perf\", \"max_time_minutes\": \"5\", \"metric\": \"mean_input_event_latency/mean_input_event_latency\", \"recipe_tester_name\": \"linux_perf_tester\", \"repeat_count\": \"2\", \"skip_gclient_ops\": \"True\", \"test_type\": \"perf\"}, \"buildername\": \"linux_perf_bisect\", \"mastername\": \"tryserver.chromium.perf\", \"recipe\": \"auto_bisect:example\", \"slavename\": \"dummyslave\"}"
],
"cwd": "[SLAVE_BUILD]",
"name": "Running Bisection"
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json ('k') | scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698