Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/config_validation_test.py

Issue 1782333002: Add bisect config validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/config_validation_test.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/config_validation_test.py b/scripts/slave/recipe_modules/auto_bisect/config_validation_test.py
new file mode 100755
index 0000000000000000000000000000000000000000..4f2014ee5b44e8a517b79c6e618adb41a444a9c4
--- /dev/null
+++ b/scripts/slave/recipe_modules/auto_bisect/config_validation_test.py
@@ -0,0 +1,100 @@
+#!/usr/bin/env python
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import copy
+import os
+import sys
+import unittest
+
+root_dir = os.path.abspath(os.path.join(
+ os.path.dirname(__file__), os.path.pardir,
+ os.path.pardir, os.path.pardir, os.path.pardir))
+sys.path.insert(0, os.path.join(root_dir, 'third_party', 'mock-1.0.1'))
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), os.path.pardir))
+
+import mock
+
+from auto_bisect import config_validation
+
+
+class ConfigValidationTest(unittest.TestCase): # pragma: no cover
+
+ def test_validate_config_empty_config(self):
+ config_validation.validate_config(config={}, schema={})
+
+ def test_validate_config_with_missing_required_fails(self):
+ with self.assertRaises(config_validation.ValidationFail):
+ config_validation.validate_config(
+ config={},
+ schema={'foo': {'type': 'integer', 'required': True}})
+
+ def test_validate_config_with_one_field_passes(self):
+ config_validation.validate_config(
+ config={'foo': 123},
+ schema={'foo': {'type': 'integer'}})
+
+ def test_validate_optional_field_passes(self):
+ config_validation.validate_config(
+ config={},
+ schema={'foo': {'type': 'integer'}})
+
+ def test_validate_not_in_schema_passes(self):
+ config_validation.validate_config(config={'foo': 'asdf'}, schema={})
+
+ def test_validate_config_larger_passing_example(self):
+ schema = {
+ 'str1': {'type': 'string'},
+ 'str2': {'type': 'string'},
+ 'int1': {'type': 'integer'},
+ 'int2': {'type': 'integer'},
+ 'rev1': {'type': 'revision'},
+ 'rev2': {'type': 'revision'},
+ 'bool1': {'type': 'boolean'},
+ 'bool2': {'type': 'boolean'},
+ }
+ config = {
+ 'str1': u'unicode-string',
+ 'str2': '',
+ 'int1': '12345',
+ 'int2': 12345,
+ 'rev1': '0123456789abcdeabcde0123456789abcdeabcde',
+ 'rev2': '12345',
+ 'bool1': True,
+ 'bool2': False,
+ }
+ config_validation.validate_config(config, schema)
+
+ def test_validate_string_failure(self):
+ with self.assertRaises(config_validation.ValidationFail):
+ config_validation.validate_config(
+ config={'x': 12345},
+ schema={'x': {'type': 'string'}})
+
+ def test_validate_integer_failure(self):
+ with self.assertRaises(config_validation.ValidationFail):
+ config_validation.validate_config(
+ config={'x': '123a'},
+ schema={'x': {'type': 'integer'}})
+
+ def test_validate_revision_failure(self):
+ with self.assertRaises(config_validation.ValidationFail):
+ config_validation.validate_config(
+ config={'x': 'abcdef'},
+ schema={'x': {'type': 'revision'}})
+
+ def test_validate_boolean_failure(self):
+ with self.assertRaises(config_validation.ValidationFail):
+ config_validation.validate_config(
+ config={'x': 'true'},
+ schema={'x': {'type': 'boolean'}})
+
+ def test_validate_choice_failure(self):
+ with self.assertRaises(config_validation.ValidationFail):
+ config_validation.validate_config(
+ config={'x': 3},
+ schema={'x': {'type': 'int', 'choices': [1, 2]}})
+
+if __name__ == '__main__':
+ unittest.main() # pragma: no cover

Powered by Google App Engine
This is Rietveld 408576698