Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc

Issue 1782313003: Do not send lofi_active_control (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
diff --git a/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc b/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
index 7ac21715f584737632ed6fe378c4e812f8be916f..e2ca344de3f93a4108f48cfbc0076130e39bc81b 100644
--- a/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
+++ b/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
@@ -139,17 +139,6 @@ class ContentLoFiDeciderTest : public testing::Test {
std::string::npos);
}
- static void VerifyLoFiExperimentHeader(
- bool expected_lofi_experiment_used,
- const net::HttpRequestHeaders& headers) {
- EXPECT_TRUE(headers.HasHeader(chrome_proxy_header()));
- std::string header_value;
- headers.GetHeader(chrome_proxy_header(), &header_value);
- EXPECT_EQ(expected_lofi_experiment_used,
- header_value.find(chrome_proxy_lo_fi_experiment_directive()) !=
- std::string::npos);
- }
-
protected:
base::MessageLoopForIO message_loop_;
net::MockClientSocketFactory mock_socket_factory_;
@@ -317,8 +306,6 @@ TEST_F(ContentLoFiDeciderTest, AutoLoFi) {
// trial and network is prohibitively slow.
bool expect_lofi_header =
tests[i].auto_lofi_enabled_group && tests[i].network_prohibitively_slow;
- bool expect_lofi_experiment_header =
- tests[i].auto_lofi_control_group && tests[i].network_prohibitively_slow;
base::FieldTrialList field_trial_list(nullptr);
if (tests[i].auto_lofi_enabled_group) {
@@ -340,7 +327,6 @@ TEST_F(ContentLoFiDeciderTest, AutoLoFi) {
NotifyBeforeSendProxyHeaders(&headers, request.get());
VerifyLoFiHeader(expect_lofi_header, headers);
- VerifyLoFiExperimentHeader(expect_lofi_experiment_header, headers);
}
}

Powered by Google App Engine
This is Rietveld 408576698