Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1782293002: S390: Printf format specifier for size_t (Closed)

Created:
4 years, 9 months ago by JoranSiu
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Printf format specifier for size_t GCC on S390 31-bit treats size_t as 'long unsigned int', which is incompatible with %d format specifier that expects an 'int'. Introduce a new V8 SIZET PREFIX to use %zd instead. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,yangguo@chromium.org BUG= Committed: https://crrev.com/59267a08f1dd3f456b83db0c7e2ae29a2a84824a Cr-Commit-Position: refs/heads/master@{#34724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M src/base/macros.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/global-handles.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/serializer.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782293002/1
4 years, 9 months ago (2016-03-10 22:48:11 UTC) #2
JoranSiu
4 years, 9 months ago (2016-03-10 23:11:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 23:19:23 UTC) #5
Yang
On 2016/03/10 23:19:23, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-11 08:23:25 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-11 14:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782293002/1
4 years, 9 months ago (2016-03-11 14:58:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 15:09:22 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 15:10:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59267a08f1dd3f456b83db0c7e2ae29a2a84824a
Cr-Commit-Position: refs/heads/master@{#34724}

Powered by Google App Engine
This is Rietveld 408576698