Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1782273002:
Make the SSLServerSocket unittests less crashy (Closed)
|
Created:
4 years, 9 months ago by Ryan Sleevi Modified:
4 years, 9 months ago Reviewers:
eroman CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake the SSLServerSocket unittests less crashy
Currently, the SSLServerSocket tests can be non-deterministically crashy
when preconditions fail, due to use of CHECKS and not ASSERT_ing that
returned/created pointers are valid before using. To make the tests
more robustly deterministic in the face of failure, and to avoid making
memory bots extra sad, liberally sprinkle ASSERT_*s throughout the
code to ensure that all pre-conditions of the code under test are
valid.
BUG=none
R=eroman@chromium.org
Committed: https://crrev.com/a5c430225dd9266b1fee40dda9d29b989c133279
Cr-Commit-Position: refs/heads/master@{#380548}
Patch Set 1 #Patch Set 2 : Fix test #Messages
Total messages: 27 (13 generated)
lgtm
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782273002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rsleevi@chromium.org
The CQ bit was unchecked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782273002/1
The CQ bit was checked by rsleevi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1782273002/#ps20001 (title: "Fix test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782273002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782273002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782273002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782273002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make the SSLServerSocket unittests less crashy Currently, the SSLServerSocket tests can be non-deterministically crashy when preconditions fail, due to use of CHECKS and not ASSERT_ing that returned/created pointers are valid before using. To make the tests more robustly deterministic in the face of failure, and to avoid making memory bots extra sad, liberally sprinkle ASSERT_*s throughout the code to ensure that all pre-conditions of the code under test are valid. BUG=none R=eroman@chromium.org ========== to ========== Make the SSLServerSocket unittests less crashy Currently, the SSLServerSocket tests can be non-deterministically crashy when preconditions fail, due to use of CHECKS and not ASSERT_ing that returned/created pointers are valid before using. To make the tests more robustly deterministic in the face of failure, and to avoid making memory bots extra sad, liberally sprinkle ASSERT_*s throughout the code to ensure that all pre-conditions of the code under test are valid. BUG=none R=eroman@chromium.org Committed: https://crrev.com/a5c430225dd9266b1fee40dda9d29b989c133279 Cr-Commit-Position: refs/heads/master@{#380548} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a5c430225dd9266b1fee40dda9d29b989c133279 Cr-Commit-Position: refs/heads/master@{#380548} |
