Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/testing/dart/http_server.dart

Issue 178223008: Replace run_selenium.py with Dart script that uses the browser controller for performance tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/browser_perf_testing/pubspec.yaml ('k') | tools/testing/dart/perf_test_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/http_server.dart
diff --git a/tools/testing/dart/http_server.dart b/tools/testing/dart/http_server.dart
index 829e70c96c81cf7b2af9cc4e494520837cfb76fa..4d676c02721b8a222ffb41016c9353e79ad706dc 100644
--- a/tools/testing/dart/http_server.dart
+++ b/tools/testing/dart/http_server.dart
@@ -101,13 +101,16 @@ class TestingServers {
List _serverList = [];
Path _buildDirectory = null;
+ Path _dartDirectory = null;
final bool useContentSecurityPolicy;
final String runtime;
TestingServers(Path buildDirectory,
this.useContentSecurityPolicy,
- [String this.runtime = 'none']) {
+ [String this.runtime = 'none', String dartDirectory]) {
_buildDirectory = TestUtils.absolutePath(buildDirectory);
+ _dartDirectory = dartDirectory == null ? TestUtils.dartDir()
+ : new Path(dartDirectory);
}
int get port => _serverList[0].port;
@@ -238,7 +241,7 @@ class TestingServers {
relativePath = new Path(
pathSegments.skip(1).join('/'));
} else if (pathSegments[0] == PREFIX_DARTDIR) {
- basePath = TestUtils.dartDir();
+ basePath = _dartDirectory;
relativePath = new Path(
pathSegments.skip(1).join('/'));
}
« no previous file with comments | « tools/testing/dart/browser_perf_testing/pubspec.yaml ('k') | tools/testing/dart/perf_test_controller.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698