Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1782193003:
Fix timestamp drift in CanvasCaptureHandler (Closed)
|
Created:
4 years, 9 months ago by emircan Modified:
4 years, 9 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix timestamp drift in CanvasCaptureHandler
This CL addresses possible bot failures such as:
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/37386
BUG=594200
Committed: https://crrev.com/43b0892d86eb8121861d41056d573b495ef518f3
Cr-Commit-Position: refs/heads/master@{#380809}
Patch Set 1 #
Messages
Total messages: 28 (15 generated)
Description was changed from ========== timestamp fix. BUG= ========== to ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses bot failures such as: https://codereview.chromium.org/1784603002/#msg18 TBR=mcasas@chromium.org ==========
emircan@chromium.org changed reviewers: + thestig@chromium.org
PTAL.
Please ask mcasas@ to review. I'm not familiar with this code at all and I'm not a code OWNER either.
Description was changed from ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses bot failures such as: https://codereview.chromium.org/1784603002/#msg18 TBR=mcasas@chromium.org ========== to ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://codereview.chromium.org/1784603002/#msg18 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
mcasas@ PTAL.
Description was changed from ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://codereview.chromium.org/1784603002/#msg18 ========== to ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... ==========
LGTM let's monitor the bots more carefully this time
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782193003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782193003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782193003/1
Description was changed from ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... ========== to ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... BUG=594200 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782193003/1
Message was sent while issue was closed.
Description was changed from ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... BUG=594200 ========== to ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... BUG=594200 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... BUG=594200 ========== to ========== Fix timestamp drift in CanvasCaptureHandler This CL addresses possible bot failures such as: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28... BUG=594200 Committed: https://crrev.com/43b0892d86eb8121861d41056d573b495ef518f3 Cr-Commit-Position: refs/heads/master@{#380809} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/43b0892d86eb8121861d41056d573b495ef518f3 Cr-Commit-Position: refs/heads/master@{#380809} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
