Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: net/quic/quic_received_packet_manager_test.cc

Issue 1782143003: Remove FEC code from receive path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115997404
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_received_packet_manager.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_received_packet_manager_test.cc
diff --git a/net/quic/quic_received_packet_manager_test.cc b/net/quic/quic_received_packet_manager_test.cc
index 4f2443c5c6ba1389fab873734a9a167fb9e1c140..535ddab47b2919434253e399066e8169f01869ee 100644
--- a/net/quic/quic_received_packet_manager_test.cc
+++ b/net/quic/quic_received_packet_manager_test.cc
@@ -203,10 +203,6 @@ class QuicReceivedPacketManagerTest : public ::testing::Test {
received_manager_.RecordPacketReceived(0u, header, receipt_time);
}
- void RecordPacketRevived(QuicPacketNumber packet_number) {
- received_manager_.RecordPacketRevived(packet_number);
- }
-
QuicConnectionStats stats_;
QuicReceivedPacketManager received_manager_;
};
@@ -354,57 +350,6 @@ TEST_F(QuicReceivedPacketManagerTest, UpdateReceivedConnectionStats) {
EXPECT_EQ(1u, stats_.packets_reordered);
}
-TEST_F(QuicReceivedPacketManagerTest, RevivedPacket) {
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(1, 0);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(3, 0);
- RecordPacketRevived(2);
-
- QuicAckFrame ack;
- received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero());
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- EXPECT_EQ(1u, ack.missing_packets.NumPacketsSlow());
- EXPECT_EQ(2u, ack.missing_packets.Min());
- EXPECT_EQ(2u, ack.latest_revived_packet);
-}
-
-TEST_F(QuicReceivedPacketManagerTest, PacketRevivedThenReceived) {
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(1, 0);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(3, 0);
- RecordPacketRevived(2);
- RecordPacketReceipt(2, 0);
-
- QuicAckFrame ack;
- received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero());
- EXPECT_TRUE(ack.missing_packets.Empty());
- EXPECT_EQ(0u, ack.latest_revived_packet);
-}
-
-TEST_F(QuicReceivedPacketManagerTest, RevivedPacketAckFrameUpdated) {
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- RecordPacketReceipt(1, 0);
- RecordPacketReceipt(3, 0);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
-
- QuicAckFrame ack;
- received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero());
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- EXPECT_EQ(1u, ack.missing_packets.NumPacketsSlow());
- EXPECT_EQ(2u, ack.missing_packets.Min());
- EXPECT_EQ(0u, ack.latest_revived_packet);
-
- RecordPacketRevived(2);
- EXPECT_TRUE(received_manager_.ack_frame_updated());
- received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero());
- EXPECT_FALSE(received_manager_.ack_frame_updated());
- EXPECT_EQ(1u, ack.missing_packets.NumPacketsSlow());
- EXPECT_EQ(2u, ack.missing_packets.Min());
- EXPECT_EQ(2u, ack.latest_revived_packet);
-}
-
} // namespace
} // namespace test
} // namespace net
« no previous file with comments | « net/quic/quic_received_packet_manager.cc ('k') | net/quic/reliable_quic_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698