Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: net/quic/quic_connection.h

Issue 1782143003: Remove FEC code from receive path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115997404
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index 48473c672a2a36bc8d1f3676ccbd627a13b72211..2dda96ce3e5f7b73c70f81bf3b4851950448f528 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -54,7 +54,6 @@ class QuicClock;
class QuicConfig;
class QuicConnection;
class QuicEncrypter;
-class QuicFecGroup;
class QuicRandom;
namespace test {
@@ -234,11 +233,6 @@ class NET_EXPORT_PRIVATE QuicConnectionDebugVisitor
virtual void OnVersionNegotiationPacket(
const QuicVersionNegotiationPacket& packet) {}
- // Called after a packet has been successfully parsed which results
- // in the revival of a packet via FEC.
- virtual void OnRevivedPacket(const QuicPacketHeader& revived_header,
- base::StringPiece payload) {}
-
// Called when the connection is closed.
virtual void OnConnectionClosed(QuicErrorCode error,
ConnectionCloseSource source) {}
@@ -390,8 +384,7 @@ class NET_EXPORT_PRIVATE QuicConnection
const QuicConnectionStats& GetStats();
// Processes an incoming UDP packet (consisting of a QuicEncryptedPacket) from
- // the peer. If processing this packet permits a packet to be revived from
- // its FEC group that packet will be revived and processed.
+ // the peer.
// In a client, the packet may be "stray" and have a different connection ID
// than that of this connection.
virtual void ProcessUdpPacket(const IPEndPoint& self_address,
@@ -442,13 +435,11 @@ class NET_EXPORT_PRIVATE QuicConnection
void OnPublicResetPacket(const QuicPublicResetPacket& packet) override;
void OnVersionNegotiationPacket(
const QuicVersionNegotiationPacket& packet) override;
- void OnRevivedPacket() override;
bool OnUnauthenticatedPublicHeader(
const QuicPacketPublicHeader& header) override;
bool OnUnauthenticatedHeader(const QuicPacketHeader& header) override;
void OnDecryptedPacket(EncryptionLevel level) override;
bool OnPacketHeader(const QuicPacketHeader& header) override;
- void OnFecProtectedPayload(base::StringPiece payload) override;
bool OnStreamFrame(const QuicStreamFrame& frame) override;
bool OnAckFrame(const QuicAckFrame& frame) override;
bool OnStopWaitingFrame(const QuicStopWaitingFrame& frame) override;
@@ -459,7 +450,6 @@ class NET_EXPORT_PRIVATE QuicConnection
bool OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame) override;
bool OnBlockedFrame(const QuicBlockedFrame& frame) override;
bool OnPathCloseFrame(const QuicPathCloseFrame& frame) override;
- void OnFecData(base::StringPiece redundnancy) override;
void OnPacketComplete() override;
// QuicPacketGenerator::DelegateInterface
@@ -517,8 +507,6 @@ class NET_EXPORT_PRIVATE QuicConnection
return server_supported_versions_;
}
- size_t NumFecGroups() const { return group_map_.size(); }
-
// Testing only.
size_t NumQueuedPackets() const { return queued_packets_.size(); }
@@ -720,7 +708,6 @@ class NET_EXPORT_PRIVATE QuicConnection
friend class test::PacketSavingConnection;
typedef std::list<SerializedPacket> QueuedPacketList;
- typedef std::map<QuicFecGroupNumber, QuicFecGroup*> FecGroupMap;
// Writes the given packet to socket, encrypted with packet's
// encryption_level. Returns true on successful write, and false if the writer
@@ -771,10 +758,6 @@ class NET_EXPORT_PRIVATE QuicConnection
// Attempts to process any queued undecryptable packets.
void MaybeProcessUndecryptablePackets();
- // If a packet can be revived from the current FEC group, then
- // revive and process the packet.
- void MaybeProcessRevivedPacket();
-
void ProcessAckFrame(const QuicAckFrame& incoming_ack);
void ProcessStopWaitingFrame(const QuicStopWaitingFrame& stop_waiting);
@@ -791,13 +774,6 @@ class NET_EXPORT_PRIVATE QuicConnection
// to be sent if there are no outstanding packets.
QuicPacketNumber GetLeastUnacked() const;
- // Get the FEC group associate with the last processed packet or nullptr, if
- // the group has already been deleted.
- QuicFecGroup* GetFecGroup();
-
- // Closes any FEC groups protecting packets before |packet_number|.
- void CloseFecGroupsBefore(QuicPacketNumber packet_number);
-
// Sets the timeout alarm to the appropriate value, if any.
void SetTimeoutAlarm();
@@ -869,7 +845,6 @@ class NET_EXPORT_PRIVATE QuicConnection
// True if the last packet has gotten far enough in the framer to be
// decrypted.
bool last_packet_decrypted_;
- bool last_packet_revived_; // True if the last packet was revived from FEC.
QuicByteCount last_size_; // Size of the last received packet.
EncryptionLevel last_decrypted_packet_level_;
QuicPacketHeader last_header_;
@@ -914,8 +889,6 @@ class NET_EXPORT_PRIVATE QuicConnection
// This is particularly important on mobile, where connections are short.
bool silent_close_enabled_;
- FecGroupMap group_map_;
-
QuicReceivedPacketManager received_packet_manager_;
QuicSentEntropyManager sent_entropy_manager_;
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698