Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1782133003: Revert of Add the missing asset file cast_shell.pak back (Closed)

Created:
4 years, 9 months ago by alokp
Modified:
4 years, 9 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, Simeon
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the missing asset file cast_shell.pak back (patchset #3 id:40001 of https://codereview.chromium.org/1776933002/ ) Reason for revert: Break chromecast gyp build: "unknown target 'assets/cast_shell.pak'" Original issue's description: > Add the missing asset file cast_shell.pak back > > All files under assets directory will be removed when building cast_shell_icudata target. We have to make sure all the asset files must be collected here. > > BUG=593277 > > Committed: https://crrev.com/c058232e6063829ab7db5dab45bdbdbb988b06d0 > Cr-Commit-Position: refs/heads/master@{#380202} TBR=michaelbai@chromium.org,halliwell@chromium.org,sanfin@chromium.org,tsunghung@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593277 Committed: https://crrev.com/89e5e9707432b52b19046f8aedee9021aae97e31 Cr-Commit-Position: refs/heads/master@{#380440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chromecast/chromecast.gyp View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alokp
Created Revert of Add the missing asset file cast_shell.pak back
4 years, 9 months ago (2016-03-10 19:10:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782133003/1
4 years, 9 months ago (2016-03-10 19:11:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 19:12:30 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:13:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89e5e9707432b52b19046f8aedee9021aae97e31
Cr-Commit-Position: refs/heads/master@{#380440}

Powered by Google App Engine
This is Rietveld 408576698