Instrument MojoShellConnectionImpl::BindToMessagePipe

Instrument MojoShellConnectionImpl::BindToMessagePipe

This adds a histogram to measure the duration of calls to
MojoShellConnectionImpl::BindToMessagePipe in child processes.

The new histogram replaces a useless one which was recently added
to measure uninteresting calls to MojoShellConnection::Create()
in renderers.

BindToMessagePipe cost should be significantly reduced in a
follow-up CL, but it will still need to do some non-trivial
amount of work. This metric will help us detect if it remains
problematic or regresses.

BUG=591742
R=ben@chromium.org

Committed: https://crrev.com/c7b3190c0ecd5b88688aa5e55d3085f0fbd40e11
Cr-Commit-Position: refs/heads/master@{#380555}

[Ken Rockot(use gerrit already), 2016-03-10 18:41:01]

rockot@chromium.org changed reviewers:
+ isherman@chromium.org

[Ben Goodger (Google), 2016-03-10 18:43:09]

Do you need finer grained resolution here? i.e. do you want to know if the
holdup is in RunnerConnection or WaitForInitialize()?

either way, lgtm

[Ken Rockot(use gerrit already), 2016-03-10 18:44:39]

Mostly I'm just interested in making sure the whole call gets fast and
stays fast. More fine-grained analysis can be done locally.

On Thu, Mar 10, 2016 at 10:43 AM, <ben@chromium.org> wrote:

> Do you need finer grained resolution here? i.e. do you want to know if the
> holdup is in RunnerConnection or WaitForInitialize()?
>
> either way, lgtm
>
> https://codereview.chromium.org/1782133002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ilya Sherman, 2016-03-10 23:44:50]

lgtm

[Ken Rockot(use gerrit already), 2016-03-11 00:03:56]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:04:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782133002/1

[commit-bot: I haz the power, 2016-03-11 00:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:40:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-03-11 00:40:38]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:41:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782133002/1

[commit-bot: I haz the power, 2016-03-11 01:14:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:14:04]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-03-11 01:18:32]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:18:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782133002/1

[commit-bot: I haz the power, 2016-03-11 01:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:48:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-03-11 05:21:09]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-03-11 05:22:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1782133002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1782133002/1

[commit-bot: I haz the power, 2016-03-11 06:17:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-11 06:20:16]

Description was changed from

==========
Instrument MojoShellConnectionImpl::BindToMessagePipe

This adds a histogram to measure the duration of calls to
MojoShellConnectionImpl::BindToMessagePipe in child processes.

The new histogram replaces a useless one which was recently added
to measure uninteresting calls to MojoShellConnection::Create()
in renderers.

BindToMessagePipe cost should be significantly reduced in a
follow-up CL, but it will still need to do some non-trivial
amount of work. This metric will help us detect if it remains
problematic or regresses.

BUG=591742
R=ben@chromium.org
==========

to

==========
Instrument MojoShellConnectionImpl::BindToMessagePipe

This adds a histogram to measure the duration of calls to
MojoShellConnectionImpl::BindToMessagePipe in child processes.

The new histogram replaces a useless one which was recently added
to measure uninteresting calls to MojoShellConnection::Create()
in renderers.

BindToMessagePipe cost should be significantly reduced in a
follow-up CL, but it will still need to do some non-trivial
amount of work. This metric will help us detect if it remains
problematic or regresses.

BUG=591742
R=ben@chromium.org

Committed: https://crrev.com/c7b3190c0ecd5b88688aa5e55d3085f0fbd40e11
Cr-Commit-Position: refs/heads/master@{#380555}
==========

[commit-bot: I haz the power, 2016-03-11 06:20:17]

Patchset 1 (id:??) landed as
https://crrev.com/c7b3190c0ecd5b88688aa5e55d3085f0fbd40e11
Cr-Commit-Position: refs/heads/master@{#380555}