Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 1782123003: Makes WindowTree take the AccessPolicy (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes WindowTree take the AccessPolicy Having callers decide the policy makes more sense, and will be useful as we add more policies (such as the director). BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/24475251b51b0e76fe011351626473034e80e332 Cr-Commit-Position: refs/heads/master@{#380777}

Patch Set 1 #

Patch Set 2 : relative #

Patch Set 3 : cleanup #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -37 lines) Patch
M components/mus/ws/access_policy.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M components/mus/ws/connection_manager.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/mus/ws/connection_manager.cc View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M components/mus/ws/default_access_policy.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/ws/default_access_policy.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M components/mus/ws/display_binding.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_access_policy.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/ws/window_manager_access_policy.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M components/mus/ws/window_tree.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M components/mus/ws/window_tree_factory.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-10 23:28:24 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-11 23:02:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123003/60001
4 years, 9 months ago (2016-03-11 23:05:03 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-11 23:11:02 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 23:11:55 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/24475251b51b0e76fe011351626473034e80e332
Cr-Commit-Position: refs/heads/master@{#380777}

Powered by Google App Engine
This is Rietveld 408576698