Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1782123002: [Telemetry] Remove new_tab benchmark & related page sets (Closed)

Created:
4 years, 9 months ago by nednguyen
Modified:
4 years, 9 months ago
Reviewers:
sullivan, qyearsley
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove new_tab benchmark & related page sets BUG=548354 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/d60af299a63309bf5763611a743f1b55dfbf3bd4 Cr-Commit-Position: refs/heads/master@{#380635}

Patch Set 1 #

Patch Set 2 : Also remove sha1 file #

Patch Set 3 : Update benchmark_smoke_unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -87 lines) Patch
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D tools/perf/benchmarks/new_tab.py View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/perf/page_sets/data/new_tab_page_page.json View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/perf/page_sets/data/new_tab_page_page_001.wpr.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/new_tab_page.py View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 38 (19 generated)
nednguyen
+Quinten: can you update the dashboard to stop tracking this?
4 years, 9 months ago (2016-03-10 17:24:12 UTC) #3
qyearsley
On 2016/03/10 at 17:24:12, nednguyen wrote: > +Quinten: can you update the dashboard to stop ...
4 years, 9 months ago (2016-03-10 17:26:03 UTC) #4
sullivan
lgtm
4 years, 9 months ago (2016-03-10 17:50:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/20001
4 years, 9 months ago (2016-03-10 17:51:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/180855)
4 years, 9 months ago (2016-03-10 18:20:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/40001
4 years, 9 months ago (2016-03-10 18:45:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/128795)
4 years, 9 months ago (2016-03-10 19:33:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/40001
4 years, 9 months ago (2016-03-10 19:36:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-10 20:47:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/40001
4 years, 9 months ago (2016-03-10 21:21:05 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/128991)
4 years, 9 months ago (2016-03-10 22:42:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/40001
4 years, 9 months ago (2016-03-10 22:55:18 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129123)
4 years, 9 months ago (2016-03-11 00:16:01 UTC) #27
nednguyen
On 2016/03/11 00:16:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-11 00:19:36 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/40001
4 years, 9 months ago (2016-03-11 00:20:52 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129196)
4 years, 9 months ago (2016-03-11 01:39:59 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782123002/40001
4 years, 9 months ago (2016-03-11 14:15:58 UTC) #34
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 15:05:02 UTC) #36
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 15:06:29 UTC) #38
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d60af299a63309bf5763611a743f1b55dfbf3bd4
Cr-Commit-Position: refs/heads/master@{#380635}

Powered by Google App Engine
This is Rietveld 408576698