Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: content/renderer/android/synchronous_compositor_output_surface.cc

Issue 1782093002: Move fallback tick handling to compositor thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/android/synchronous_compositor_output_surface.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/android/synchronous_compositor_output_surface.h" 5 #include "content/renderer/android/synchronous_compositor_output_surface.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "cc/output/compositor_frame.h" 10 #include "cc/output/compositor_frame.h"
11 #include "cc/output/context_provider.h" 11 #include "cc/output/context_provider.h"
12 #include "cc/output/output_surface_client.h" 12 #include "cc/output/output_surface_client.h"
13 #include "cc/output/software_output_device.h" 13 #include "cc/output/software_output_device.h"
14 #include "content/renderer/android/synchronous_compositor_external_begin_frame_s ource.h" 14 #include "content/renderer/android/synchronous_compositor_external_begin_frame_s ource.h"
15 #include "content/renderer/android/synchronous_compositor_registry.h" 15 #include "content/renderer/android/synchronous_compositor_registry.h"
16 #include "content/renderer/gpu/frame_swap_message_queue.h" 16 #include "content/renderer/gpu/frame_swap_message_queue.h"
17 #include "gpu/command_buffer/client/context_support.h" 17 #include "gpu/command_buffer/client/context_support.h"
18 #include "gpu/command_buffer/client/gles2_interface.h" 18 #include "gpu/command_buffer/client/gles2_interface.h"
19 #include "gpu/command_buffer/common/gpu_memory_allocation.h" 19 #include "gpu/command_buffer/common/gpu_memory_allocation.h"
20 #include "third_party/skia/include/core/SkCanvas.h" 20 #include "third_party/skia/include/core/SkCanvas.h"
21 #include "ui/gfx/geometry/rect_conversions.h" 21 #include "ui/gfx/geometry/rect_conversions.h"
22 #include "ui/gfx/skia_util.h" 22 #include "ui/gfx/skia_util.h"
23 #include "ui/gfx/transform.h" 23 #include "ui/gfx/transform.h"
24 24
25 namespace content { 25 namespace content {
26 26
27 namespace { 27 namespace {
28 28
29 const int64_t kFallbackTickTimeoutInMilliseconds = 100;
30
29 // Do not limit number of resources, so use an unrealistically high value. 31 // Do not limit number of resources, so use an unrealistically high value.
30 const size_t kNumResourcesLimit = 10 * 1000 * 1000; 32 const size_t kNumResourcesLimit = 10 * 1000 * 1000;
31 33
32 } // namespace 34 } // namespace
33 35
34 class SynchronousCompositorOutputSurface::SoftwareDevice 36 class SynchronousCompositorOutputSurface::SoftwareDevice
35 : public cc::SoftwareOutputDevice { 37 : public cc::SoftwareOutputDevice {
36 public: 38 public:
37 SoftwareDevice(SynchronousCompositorOutputSurface* surface) 39 SoftwareDevice(SynchronousCompositorOutputSurface* surface)
38 : surface_(surface) { 40 : surface_(surface) {
(...skipping 29 matching lines...) Expand all
68 context_provider, 70 context_provider,
69 worker_context_provider, 71 worker_context_provider,
70 scoped_ptr<cc::SoftwareOutputDevice>(new SoftwareDevice(this))), 72 scoped_ptr<cc::SoftwareOutputDevice>(new SoftwareDevice(this))),
71 routing_id_(routing_id), 73 routing_id_(routing_id),
72 registry_(registry), 74 registry_(registry),
73 registered_(false), 75 registered_(false),
74 sync_client_(nullptr), 76 sync_client_(nullptr),
75 current_sw_canvas_(nullptr), 77 current_sw_canvas_(nullptr),
76 memory_policy_(0u), 78 memory_policy_(0u),
77 did_swap_(false), 79 did_swap_(false),
78 frame_swap_message_queue_(frame_swap_message_queue) { 80 frame_swap_message_queue_(frame_swap_message_queue) {
boliu 2016/03/14 15:33:55 initialize fallback_tick_pending_
Tobias Sargeant 2016/03/14 15:40:48 Done.
79 thread_checker_.DetachFromThread(); 81 thread_checker_.DetachFromThread();
80 DCHECK(registry_); 82 DCHECK(registry_);
81 capabilities_.adjust_deadline_for_parent = false; 83 capabilities_.adjust_deadline_for_parent = false;
82 capabilities_.delegated_rendering = true; 84 capabilities_.delegated_rendering = true;
83 memory_policy_.priority_cutoff_when_visible = 85 memory_policy_.priority_cutoff_when_visible =
84 gpu::MemoryAllocation::CUTOFF_ALLOW_NICE_TO_HAVE; 86 gpu::MemoryAllocation::CUTOFF_ALLOW_NICE_TO_HAVE;
85 } 87 }
86 88
87 SynchronousCompositorOutputSurface::~SynchronousCompositorOutputSurface() {} 89 SynchronousCompositorOutputSurface::~SynchronousCompositorOutputSurface() {}
88 90
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 127
126 void SynchronousCompositorOutputSurface::SwapBuffers( 128 void SynchronousCompositorOutputSurface::SwapBuffers(
127 cc::CompositorFrame* frame) { 129 cc::CompositorFrame* frame) {
128 DCHECK(CalledOnValidThread()); 130 DCHECK(CalledOnValidThread());
129 DCHECK(sync_client_); 131 DCHECK(sync_client_);
130 sync_client_->SwapBuffers(frame); 132 sync_client_->SwapBuffers(frame);
131 client_->DidSwapBuffers(); 133 client_->DidSwapBuffers();
132 did_swap_ = true; 134 did_swap_ = true;
133 } 135 }
134 136
137 void SynchronousCompositorOutputSurface::FallbackTickFired() {
138 DCHECK(CalledOnValidThread());
139 TRACE_EVENT0("renderer",
140 "SynchronousCompositorOutputSurface::FallbackTickFired");
141 SkBitmap bitmap;
142 bitmap.allocN32Pixels(1, 1);
143 bitmap.eraseColor(0);
144 SkCanvas canvas(bitmap);
145 DemandDrawSw(&canvas);
146 fallback_tick_pending_ = false;
147 }
148
135 void SynchronousCompositorOutputSurface::Invalidate() { 149 void SynchronousCompositorOutputSurface::Invalidate() {
136 DCHECK(CalledOnValidThread()); 150 DCHECK(CalledOnValidThread());
137 if (sync_client_) 151 if (sync_client_)
138 sync_client_->Invalidate(); 152 sync_client_->Invalidate();
153
154 if (!fallback_tick_pending_) {
155 fallback_tick_.Reset(
156 base::Bind(&SynchronousCompositorOutputSurface::FallbackTickFired,
157 base::Unretained(this)));
158 base::MessageLoop::current()->PostDelayedTask(
159 FROM_HERE, fallback_tick_.callback(),
160 base::TimeDelta::FromMilliseconds(kFallbackTickTimeoutInMilliseconds));
161 fallback_tick_pending_ = true;
162 }
139 } 163 }
140 164
141 void SynchronousCompositorOutputSurface::DemandDrawHw( 165 void SynchronousCompositorOutputSurface::DemandDrawHw(
142 const gfx::Size& surface_size, 166 const gfx::Size& surface_size,
143 const gfx::Transform& transform, 167 const gfx::Transform& transform,
144 const gfx::Rect& viewport, 168 const gfx::Rect& viewport,
145 const gfx::Rect& clip, 169 const gfx::Rect& clip,
146 const gfx::Rect& viewport_rect_for_tile_priority, 170 const gfx::Rect& viewport_rect_for_tile_priority,
147 const gfx::Transform& transform_for_tile_priority) { 171 const gfx::Transform& transform_for_tile_priority) {
148 DCHECK(CalledOnValidThread()); 172 DCHECK(CalledOnValidThread());
149 DCHECK(HasClient()); 173 DCHECK(HasClient());
150 DCHECK(context_provider_.get()); 174 DCHECK(context_provider_.get());
175 fallback_tick_.Cancel();
176 fallback_tick_pending_ = false;
151 177
152 surface_size_ = surface_size; 178 surface_size_ = surface_size;
153 client_->SetExternalTilePriorityConstraints(viewport_rect_for_tile_priority, 179 client_->SetExternalTilePriorityConstraints(viewport_rect_for_tile_priority,
154 transform_for_tile_priority); 180 transform_for_tile_priority);
155 const bool software_draw = false; 181 const bool software_draw = false;
156 InvokeComposite(transform, viewport, clip, software_draw); 182 InvokeComposite(transform, viewport, clip, software_draw);
157 } 183 }
158 184
159 void SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas* canvas) { 185 void SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas* canvas) {
160 DCHECK(CalledOnValidThread()); 186 DCHECK(CalledOnValidThread());
161 DCHECK(canvas); 187 DCHECK(canvas);
162 DCHECK(!current_sw_canvas_); 188 DCHECK(!current_sw_canvas_);
189 fallback_tick_.Cancel();
190 fallback_tick_pending_ = false;
163 191
164 base::AutoReset<SkCanvas*> canvas_resetter(&current_sw_canvas_, canvas); 192 base::AutoReset<SkCanvas*> canvas_resetter(&current_sw_canvas_, canvas);
165 193
166 SkIRect canvas_clip; 194 SkIRect canvas_clip;
167 canvas->getClipDeviceBounds(&canvas_clip); 195 canvas->getClipDeviceBounds(&canvas_clip);
168 gfx::Rect clip = gfx::SkIRectToRect(canvas_clip); 196 gfx::Rect clip = gfx::SkIRectToRect(canvas_clip);
169 197
170 gfx::Transform transform(gfx::Transform::kSkipInitialization); 198 gfx::Transform transform(gfx::Transform::kSkipInitialization);
171 transform.matrix() = canvas->getTotalMatrix(); // Converts 3x3 matrix to 4x4. 199 transform.matrix() = canvas->getTotalMatrix(); // Converts 3x3 matrix to 4x4.
172 200
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 scoped_ptr<FrameSwapMessageQueue::SendMessageScope> send_message_scope = 257 scoped_ptr<FrameSwapMessageQueue::SendMessageScope> send_message_scope =
230 frame_swap_message_queue_->AcquireSendMessageScope(); 258 frame_swap_message_queue_->AcquireSendMessageScope();
231 frame_swap_message_queue_->DrainMessages(messages); 259 frame_swap_message_queue_->DrainMessages(messages);
232 } 260 }
233 261
234 bool SynchronousCompositorOutputSurface::CalledOnValidThread() const { 262 bool SynchronousCompositorOutputSurface::CalledOnValidThread() const {
235 return thread_checker_.CalledOnValidThread(); 263 return thread_checker_.CalledOnValidThread();
236 } 264 }
237 265
238 } // namespace content 266 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/android/synchronous_compositor_output_surface.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698