Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1782083002: Switch SkColorFilterImageFilter over to new onFilterImage interface (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix bug and add comment #

Patch Set 3 : remove header #

Patch Set 4 : Update to ToT #

Patch Set 5 : update to ToT (again) #

Patch Set 6 : Handle empty SkBitmaps in makeTextureImage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M include/effects/SkColorFilterImageFilter.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 2 3 4 3 chunks +35 lines, -27 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
robertphillips
4 years, 9 months ago (2016-03-22 19:25:03 UTC) #4
Stephen White
LGTM
4 years, 9 months ago (2016-03-22 20:01:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782083002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782083002/80001
4 years, 9 months ago (2016-03-23 11:45:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-23 12:00:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782083002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782083002/80001
4 years, 9 months ago (2016-03-23 16:41:21 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/ec950c4d215c6141b31b98ed6a8182a97baeb8b9
4 years, 9 months ago (2016-03-23 16:42:16 UTC) #14
robertphillips
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1829993003/ by robertphillips@google.com. ...
4 years, 9 months ago (2016-03-23 23:37:57 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782083002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782083002/100001
4 years, 9 months ago (2016-03-24 13:16:36 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 13:27:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782083002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782083002/100001
4 years, 9 months ago (2016-03-24 13:30:28 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 13:31:30 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/83f2e5ac136c006a7839945f8420f978b672b2cd

Powered by Google App Engine
This is Rietveld 408576698