chrome/browser/engagement/site_engagement_service.cc - Issue 1782053004: Change how the quota system computes the total poolsize for temporary storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 1782053004: Change how the quota system computes the total poolsize for temporary storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_eviction_policy_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service.cc

diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc

index ae6d93e85fa0b58c8dd16264732582bf59886a0e..358f8e7748d3c1115e8c8dd885946ad7e1afb265 100644

--- a/chrome/browser/engagement/site_engagement_service.cc

+++ b/chrome/browser/engagement/site_engagement_service.cc

@@ -20,7 +20,6 @@

#include "base/values.h"

#include "chrome/browser/banners/app_banner_settings_helper.h"

#include "chrome/browser/content_settings/host_content_settings_map_factory.h"

-#include "chrome/browser/engagement/site_engagement_eviction_policy.h"

#include "chrome/browser/engagement/site_engagement_metrics.h"

#include "chrome/browser/engagement/site_engagement_score.h"

#include "chrome/browser/engagement/site_engagement_service_factory.h"

@@ -91,7 +90,6 @@ bool SiteEngagementService::IsEnabled() {

// return true immediately.

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableSiteEngagementService) ||

- SiteEngagementEvictionPolicy::IsEnabled() ||

AppBannerSettingsHelper::ShouldUseSiteEngagementScore()) {

return true;

}