Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: content/public/browser/content_browser_client.cc

Issue 1782053004: Change how the quota system computes the total poolsize for temporary storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed QuotaEvictionPolicy Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index 6cbb744a4ea1f4b287ca77411cc7e4cca2ccb8cd..a591b1fe415f4a6c92127fc284f1908ac0a59845 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -6,6 +6,7 @@
#include "base/files/file_path.h"
#include "base/guid.h"
+#include "base/logging.h"
#include "build/build_config.h"
#include "content/public/browser/client_certificate_delegate.h"
#include "content/public/browser/memory_coordinator_delegate.h"
@@ -224,10 +225,14 @@ QuotaPermissionContext* ContentBrowserClient::CreateQuotaPermissionContext() {
return nullptr;
}
-std::unique_ptr<storage::QuotaEvictionPolicy>
-ContentBrowserClient::GetTemporaryStorageEvictionPolicy(
- content::BrowserContext* context) {
- return std::unique_ptr<storage::QuotaEvictionPolicy>();
+void ContentBrowserClient::GetQuotaSettings(
+ BrowserContext* context,
+ StoragePartition* partition,
+ const storage::OptionalQuotaSettingsCallback& callback) {
+ // By default, no quota is provided, embedders should override.
+ LOG(WARNING) << "You must override ContentBrowserClient::GetQuotaSettings "
+ << "to provide storage quota.";
kinuko 2016/11/15 07:39:10 We don't seem to have this kind of WARNING logs el
michaeln 2016/11/21 21:52:48 Done, I moved the logging into the QuotaManager wh
+ callback.Run(storage::GetNoQuotaSettings());
}
void ContentBrowserClient::SelectClientCertificate(

Powered by Google App Engine
This is Rietveld 408576698