Change how the quota system computes the total poolsize for temporary storage

storage/browser/quota/quota_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef STORAGE_BROWSER_QUOTA_QUOTA_MANAGER_H_
 #define STORAGE_BROWSER_QUOTA_QUOTA_MANAGER_H_
 
 #include <stdint.h>
 
 #include <deque>
@@ skipping 432 matching lines @@
   void DidGetAvailableSpace(int64_t space);
   void DidDatabaseWork(bool success);
 
   void DeleteOnCorrectThread() const;
 
   void PostTaskAndReplyWithResultForDBThread(
       const tracked_objects::Location& from_here,
       const base::Callback<bool(QuotaDatabase*)>& task,
       const base::Callback<void(bool)>& reply);
 
+  static void CalculateTemporaryPoolSize(
+      GetVolumeInfoFn get_vol_info_fn,
+      const base::FilePath& profile_path,
+      const QuotaCallback& callback,
+      const scoped_refptr<base::TaskRunner>& reply_runner);

[jsbell, 2016/03/23 18:08:29]

Passing in a reply task runner seems odd. I'd expect the caller to expect to be
called back on the same thread, and pass in a callback that proxies to the other
thread if necessary so this utility is ignorant of that complexity.

(Seems like that should be a pattern factored out somewhere.)

[michaeln, 2016/04/07 00:32:34]

Done.

   static int64_t CallGetAmountOfFreeDiskSpace(
       GetVolumeInfoFn get_vol_info_fn,
       const base::FilePath& profile_path);
   static bool GetVolumeInfo(const base::FilePath& path,
                             uint64_t* available_space,
                             uint64_t* total_size);
 
   const bool is_incognito_;
   const base::FilePath profile_path_;
 
@@ skipping 51 matching lines @@
 
 struct QuotaManagerDeleter {
   static void Destruct(const QuotaManager* manager) {
     manager->DeleteOnCorrectThread();
   }
 };
 
 }  // namespace storage
 
 #endif  // STORAGE_BROWSER_QUOTA_QUOTA_MANAGER_H_