Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1782043004: [heap] Use PageParallelJob for parallel evacuation (Closed)

Created:
4 years, 9 months ago by Michael Lippautz
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use PageParallelJob for parallel evacuation Move evacuation of new and old space pages to the provided framework for parallelization. Drive-by-fix: Remove left overs from POPULAR_PAGE flag. BUG=chromium:524425 LOG=N Committed: https://crrev.com/4566531c6e593ae8bffc2ef96f82c91d15a68acf Cr-Commit-Position: refs/heads/master@{#34687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -215 lines) Patch
M src/heap/mark-compact.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +85 lines, -183 lines 0 comments Download
M src/heap/page-parallel-job.h View 4 chunks +9 lines, -5 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +1 line, -21 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Michael Lippautz
Ulan: PTAL Marcel: FYI
4 years, 9 months ago (2016-03-10 17:39:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782043004/1
4 years, 9 months ago (2016-03-10 17:39:51 UTC) #6
ulan
lgtm, nice!
4 years, 9 months ago (2016-03-10 17:46:02 UTC) #7
Marcel Hlopko
Shorter, cleaner, wonderful :)
4 years, 9 months ago (2016-03-10 18:00:43 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 18:01:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782043004/1
4 years, 9 months ago (2016-03-10 18:03:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 18:10:36 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 18:11:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4566531c6e593ae8bffc2ef96f82c91d15a68acf
Cr-Commit-Position: refs/heads/master@{#34687}

Powered by Google App Engine
This is Rietveld 408576698