Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1782013002: [compiler] Sidestep the interpreter for generator functions. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Sidestep the interpreter for generator functions. This ensures the interpreter is not tasked with compiling generator functions. It currently does not support suspending activations at yielding points, but we still want to be able to activate it for the rest of JavaScript in the meantime. R=rmcilroy@chromium.org BUG=v8:4681 LOG=n Committed: https://crrev.com/899105c0bc92c9785284cfeb5bcbfec9a370995b Cr-Commit-Position: refs/heads/master@{#34672}

Patch Set 1 #

Patch Set 2 : One more test. #

Total comments: 2

Patch Set 3 : Also for test262. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M src/compiler.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download
M test/test262/test262.status View 1 2 3 3 chunks +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-10 09:28:57 UTC) #2
rmcilroy
Could you also update test262.status as well please? I've just cced you on a thread ...
4 years, 9 months ago (2016-03-10 10:15:24 UTC) #3
Michael Starzinger
Yes, will adapt test262 expectations as well. https://codereview.chromium.org/1782013002/diff/20001/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1782013002/diff/20001/test/mjsunit/mjsunit.status#newcode827 test/mjsunit/mjsunit.status:827: 'messages': [FAIL], ...
4 years, 9 months ago (2016-03-10 10:42:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1782013002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1782013002/80001
4 years, 9 months ago (2016-03-10 13:08:43 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-10 13:20:41 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 13:22:00 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/899105c0bc92c9785284cfeb5bcbfec9a370995b
Cr-Commit-Position: refs/heads/master@{#34672}

Powered by Google App Engine
This is Rietveld 408576698