Simplify the VM's typed_data constructors.

Simplify the VM's typed_data constructors.

Remove _new native functions to have one indirection less
when constructing typed data lists.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/bec43a3b8f5c132153321e87ea527d8dc469834f

[Florian Schneider, 2016-03-10 08:04:06]

fschneider@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-03-10 08:22:53]

lgtm

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.cc
File runtime/lib/typed_data.cc (right):

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.cc#n...
runtime/lib/typed_data.cc:168: GET_NON_NULL_NATIVE_ARGUMENT(Smi, length,
arguments->NativeArgAt(1));        \
Can you add a comment that the first argument is the type to the factory
constructor and is ignored.

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.dart...
runtime/lib/typed_data.dart:960: }
Not sure why we have this utility method too, there is just one place it us used
and we could directly do a new _Int8Array(length) over there (saves one function
entry).

[Florian Schneider, 2016-03-10 08:37:18]

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.cc
File runtime/lib/typed_data.cc (right):

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.cc#n...
runtime/lib/typed_data.cc:168: GET_NON_NULL_NATIVE_ARGUMENT(Smi, length,
arguments->NativeArgAt(1));        \
On 2016/03/10 08:22:53, siva wrote:
> Can you add a comment that the first argument is the type to the factory
> constructor and is ignored.

Done.

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/1782003002/diff/1/runtime/lib/typed_data.dart...
runtime/lib/typed_data.dart:960: }
On 2016/03/10 08:22:53, siva wrote:
> Not sure why we have this utility method too, there is just one place it us
used
> and we could directly do a new _Int8Array(length) over there (saves one
function
> entry).

I think this is used as a generic factory to create a list of the same type as
the receiver.

[Florian Schneider, 2016-03-10 08:38:13]

Description was changed from

==========
Simplify the VM's typed_data constructors.

Remove _new native functions to have one indirection less
when constructing typed data lists.

BUG=
==========

to

==========
Simplify the VM's typed_data constructors.

Remove _new native functions to have one indirection less
when constructing typed data lists.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bec43a3b8f5c132153321e87ea527d8dc469834f
==========

[Florian Schneider, 2016-03-10 08:38:15]

Committed patchset #2 (id:20001) manually as
bec43a3b8f5c132153321e87ea527d8dc469834f (presubmit successful).