chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc - Issue 1781983002: [Downloads] Introduce GUIDs for downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Issue 1781983002: [Downloads] Introduce GUIDs for downloads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/download/download_manager_service_unittest.cc ('K') | « chrome/browser/download/download_ui_controller_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc » ('j') | components/history/core/browser/download_row.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

index b0055284beb381b16bcab4e89c5511dfa598bfdb..df6e30f10ab814f86cfd9f8590fbdae3aba692a7 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

@@ -12,6 +12,7 @@

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

+#include "base/guid.h"

#include "base/json/json_reader.h"

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

@@ -426,7 +427,7 @@ class DownloadExtensionTest : public ExtensionApiTest {

url_chain.push_back(GURL());

for (size_t i = 0; i < count; ++i) {

DownloadItem* item = GetOnRecordManager()->CreateDownloadItem(

- content::DownloadItem::kInvalidId + 1 + i,

+ base::GenerateGUID(), content::DownloadItem::kInvalidId + 1 + i,

downloads_directory().Append(history_info[i].filename),

downloads_directory().Append(history_info[i].filename), url_chain,

GURL(), // URL Chain, referrer