chrome/browser/download/download_ui_controller_unittest.cc - Issue 1781983002: [Downloads] Introduce GUIDs for downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 1781983002: [Downloads] Introduce GUIDs for downloads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index 0e458eb91584404afab08d3e7e027b4706db6ab3..f1be1c7613d7a2680477452e06c92748aae6278f 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -206,8 +206,12 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {

EXPECT_CALL(*item, GetBrowserContext())

.WillRepeatedly(Return(browser_context()));

EXPECT_CALL(*item, GetId()).WillRepeatedly(Return(1));

- EXPECT_CALL(*item, GetTargetFilePath()).WillRepeatedly(

- ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));

+ EXPECT_CALL(*item, GetGuid())

+ .WillRepeatedly(

+ ReturnRefOfCopy(std::string("14CA04AF-ECEC-4B13-8829-817477EFAB83")));

+ EXPECT_CALL(*item, GetTargetFilePath())

+ .WillRepeatedly(

+ ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));

EXPECT_CALL(*item, GetFullPath()).WillRepeatedly(

ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));

EXPECT_CALL(*item, GetState())