Chromium Code Reviews
DescriptionRevert of [sqlite] sql::Recovery working under USE_SYSTEM_SQLITE. (patchset #2 id:20001 of https://codereview.chromium.org/1782633002/ )
Reason for revert:
Causing compile failures on iOS:
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/2931
https://build.chromium.org/p/chromium.mac/builders/iOS_Device_GN/builds/2630
Original issue's description:
> [sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.
>
> Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover
> implementation and tests. third_party/sqlite includes sqlite_recover
> library for the USE_SYSTEM_SQLITE case, with recover.c compiled against
> the system version of SQLite.
>
> Additionally remove interiorCursorEOF() from recover.c, as it was
> unused, rather than adding a compile flag to allow it.
>
> [Relands https://codereview.chromium.org/1757653002/ ]
>
> BUG=584407
> TBR=sdefresne@chromium.org
>
> Committed: https://crrev.com/81bdd5bca887096575be7d13127095ed56b3d3c4
> Cr-Commit-Position: refs/heads/master@{#380287}
TBR=sdefresne@chromium.org,shess@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584407
Committed: https://crrev.com/fb9ae22304e7322598f0d9518015f9b5508d1466
Cr-Commit-Position: refs/heads/master@{#380311}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||