Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1781973002: Revert of [sqlite] sql::Recovery working under USE_SYSTEM_SQLITE. (Closed)

Created:
4 years, 9 months ago by tsergeant
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sqlite] sql::Recovery working under USE_SYSTEM_SQLITE. (patchset #2 id:20001 of https://codereview.chromium.org/1782633002/ ) Reason for revert: Causing compile failures on iOS: https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/2931 https://build.chromium.org/p/chromium.mac/builders/iOS_Device_GN/builds/2630 Original issue's description: > [sqlite] sql::Recovery working under USE_SYSTEM_SQLITE. > > Removes the USE_SYSTEM_SQLITE conditional sections in sql::Recover > implementation and tests. third_party/sqlite includes sqlite_recover > library for the USE_SYSTEM_SQLITE case, with recover.c compiled against > the system version of SQLite. > > Additionally remove interiorCursorEOF() from recover.c, as it was > unused, rather than adding a compile flag to allow it. > > [Relands https://codereview.chromium.org/1757653002/ ] > > BUG=584407 > TBR=sdefresne@chromium.org > > Committed: https://crrev.com/81bdd5bca887096575be7d13127095ed56b3d3c4 > Cr-Commit-Position: refs/heads/master@{#380287} TBR=sdefresne@chromium.org,shess@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584407 Committed: https://crrev.com/fb9ae22304e7322598f0d9518015f9b5508d1466 Cr-Commit-Position: refs/heads/master@{#380311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -40 lines) Patch
M sql/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sql/recovery.cc View 3 chunks +18 lines, -1 line 0 comments Download
M sql/recovery_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 2 chunks +0 lines, -13 lines 0 comments Download
M third_party/sqlite/src/src/recover.c View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tsergeant
Created Revert of [sqlite] sql::Recovery working under USE_SYSTEM_SQLITE.
4 years, 9 months ago (2016-03-10 02:26:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781973002/1
4 years, 9 months ago (2016-03-10 02:26:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 02:27:37 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 02:30:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb9ae22304e7322598f0d9518015f9b5508d1466
Cr-Commit-Position: refs/heads/master@{#380311}

Powered by Google App Engine
This is Rietveld 408576698