Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1781933003: [cleanup] Remove unnecessary ClassifyAndRewriteReferenceExpression method (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove unnecessary ClassifyAndRewriteReferenceExpression method Now that the destructuring flags are gone, we always call CheckAndRewriteReferenceExpression, so unified the two methods again. Also cleaned up the code within, e.g. removing unnecessary Scanner::Location construction. Committed: https://crrev.com/7d0252db445669a409dfd9763eb627cc84e565a1 Cr-Commit-Position: refs/heads/master@{#34699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -33 lines) Patch
M src/parsing/parser-base.h View 2 chunks +13 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
4 years, 9 months ago (2016-03-11 00:05:01 UTC) #1
adamk
4 years, 9 months ago (2016-03-11 00:05:16 UTC) #3
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-11 01:33:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781933003/1
4 years, 9 months ago (2016-03-11 01:40:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 01:41:50 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 01:42:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d0252db445669a409dfd9763eb627cc84e565a1
Cr-Commit-Position: refs/heads/master@{#34699}

Powered by Google App Engine
This is Rietveld 408576698