Android: support http referrers for context menu navigations.

Android: support http referrers for context menu navigations.

This patch provides the support needed for setting http referrers on URL
loads triggered from the context menu:

- adds Referrer.java holder corresponding to the native
  content::Referrer
- ContextMenuParams.java now holds a Referrer field set (along with
  sanitization) by ContextMenuHelper
- ContextMenuItemDelegate methods that trigger new navigations accept a
  Referrer parameter (save for OpenInNewIncognitoTab, as we drop the
  referrer in this case)
- LoadUrlParams.java also gets a Referrer field, so that embedders can
  set it in their ContextMenuItemDelegate implementations

BUG=340295
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255370

[ppi, 2014-03-05 19:59:30]

Please take a look.

[ppi, 2014-03-05 20:01:45]

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
File chrome/browser/ui/android/context_menu_helper.cc (right):

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
chrome/browser/ui/android/context_menu_helper.cc:100: // TODO(ppi): consider
extracting into a helper method in GURL?
As for this TODO - I also sent https://codereview.chromium.org/185133005/ , but
I'm not sure if it's worth it.

[Ted C, 2014-03-05 22:20:53]

lgtm

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
File chrome/browser/ui/android/context_menu_helper.cc (right):

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
chrome/browser/ui/android/context_menu_helper.cc:100: // TODO(ppi): consider
extracting into a helper method in GURL?
On 2014/03/05 20:01:45, ppi wrote:
> As for this TODO - I also sent https://codereview.chromium.org/185133005/ ,
but
> I'm not sure if it's worth it.

I would say that if the other review doesn't go through, then this TODO should
be removed.

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
File chrome/browser/ui/android/context_menu_helper.h (right):

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
chrome/browser/ui/android/context_menu_helper.h:44: // Strips the referring url
from username, password and ref fields.
s/from/of

[ppi, 2014-03-06 11:41:03]

Thanks!

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
File chrome/browser/ui/android/context_menu_helper.cc (right):

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
chrome/browser/ui/android/context_menu_helper.cc:100: // TODO(ppi): consider
extracting into a helper method in GURL?
On 2014/03/05 22:20:53, Ted C wrote:
> On 2014/03/05 20:01:45, ppi wrote:
> > As for this TODO - I also sent https://codereview.chromium.org/185133005/ ,
> but
> > I'm not sure if it's worth it.
> 
> I would say that if the other review doesn't go through, then this TODO should
> be removed.

Agreed. I will remove it already and include this piece in the other review.

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
File chrome/browser/ui/android/context_menu_helper.h (right):

https://codereview.chromium.org/178193033/diff/1/chrome/browser/ui/android/co...
chrome/browser/ui/android/context_menu_helper.h:44: // Strips the referring url
from username, password and ref fields.
On 2014/03/05 22:20:53, Ted C wrote:
> s/from/of

Done.

[ppi, 2014-03-06 11:41:18]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-06 11:42:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/178193033/40001

[commit-bot: I haz the power, 2014-03-06 11:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 11:44:11]

Try jobs failed on following builders: mac_chromium_rel

[ppi, 2014-03-06 11:44:35]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-06 11:44:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/178193033/40001

[commit-bot: I haz the power, 2014-03-06 12:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 12:42:57]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[ppi, 2014-03-06 14:22:50]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-06 14:24:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/178193033/60001

[commit-bot: I haz the power, 2014-03-06 16:49:22]

Change committed as 255370