Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/tools/build/repack_locales.py

Issue 178193032: Fix ui_unittests building with enable_autofill_dialog=0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix duplicate arguments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_repack_locales.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/repack_locales.py
diff --git a/chrome/tools/build/repack_locales.py b/chrome/tools/build/repack_locales.py
index 3acaa047f45224cedcb0055f2ec0a7463d40bfbd..6f5f7c2df283d6f378476a64361c66bff32acc34 100755
--- a/chrome/tools/build/repack_locales.py
+++ b/chrome/tools/build/repack_locales.py
@@ -30,6 +30,7 @@ INT_DIR = None
OS = None
USE_ASH = False
+ENABLE_AUTOFILL_DIALOG = False
WHITELIST = None
@@ -108,7 +109,7 @@ def calc_inputs(locale):
inputs.append(os.path.join(SHARE_INT_DIR, 'extensions', 'strings',
'extensions_strings_%s.pak' % locale))
- if OS != 'ios' and OS != 'android':
+ if ENABLE_AUTOFILL_DIALOG and OS != 'ios' and OS != 'android':
#e.g. '<(SHARED_INTERMEDIATE_DIR)/third_party/libaddressinput/
# libaddressinput_strings_da.pak',
inputs.append(os.path.join(SHARE_INT_DIR, 'third_party', 'libaddressinput',
@@ -172,6 +173,7 @@ def DoMain(argv):
global OS
global USE_ASH
global WHITELIST
+ global ENABLE_AUTOFILL_DIALOG
global EXTRA_INPUT_FILES
parser = optparse.OptionParser("usage: %prog [options] locales")
@@ -196,6 +198,9 @@ def DoMain(argv):
help="Whether to include ash strings")
parser.add_option("--whitelist", action="store", help="Full path to the "
"whitelist used to filter output pak file resource IDs")
+ parser.add_option("--enable-autofill-dialog", action="store",
+ dest="enable_autofill_dialog",
+ help="Whether to include strings for autofill dialog")
options, locales = parser.parse_args(argv)
if not locales:
@@ -211,6 +216,7 @@ def DoMain(argv):
OS = options.os
USE_ASH = options.use_ash == '1'
WHITELIST = options.whitelist
+ ENABLE_AUTOFILL_DIALOG = options.enable_autofill_dialog == '1'
if not OS:
if sys.platform == 'darwin':
« no previous file with comments | « chrome/chrome_repack_locales.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698