Fix ui_unittests building with enable_autofill_dialog=0

Fix ui_unittests building with enable_autofill_dialog=0

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270107

[Evan Stade, 2014-03-05 23:16:06]

-estade, +kerz

[kerz_chromium, 2014-03-05 23:17:08]

On 2014/03/05 23:16:06, Evan Stade wrote:
> -estade, +kerz

lgtm, seems fine, but not sure I'm the right person to review this.

[Evan Stade, 2014-03-05 23:23:08]

On 2014/03/05 23:17:08, kerz_chromium wrote:
> On 2014/03/05 23:16:06, Evan Stade wrote:
> > -estade, +kerz
> 
> lgtm, seems fine, but not sure I'm the right person to review this.

You are an owner of chrome/tools/build if I'm not mistaken.

[Jiang Jiang, 2014-03-14 12:55:19]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-03-14 12:55:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiangj@opera.com/178193032/1

[commit-bot: I haz the power, 2014-03-14 13:47:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 13:47:27]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, components_unittests, content_unittests, crypto_unittests,
net_unittests, sql_unittests, ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Jiang Jiang, 2014-03-15 20:02:44]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-03-15 20:02:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jiangj@opera.com/178193032/1

[commit-bot: I haz the power, 2014-03-15 20:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-15 20:35:41]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, components_unittests, content_unittests, crypto_unittests,
net_unittests, sql_unittests, ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Jiang Jiang, 2014-05-12 10:08:47]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-05-12 10:09:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jiangj@opera.com/178193032/1

[commit-bot: I haz the power, 2014-05-12 10:18:30]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-12 10:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-12 10:21:35]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Jiang Jiang, 2014-05-12 11:25:55]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-05-12 11:26:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jiangj@opera.com/178193032/20001

[Jiang Jiang, 2014-05-12 11:58:12]

The CQ bit was unchecked by jiangj@opera.com

[Jiang Jiang, 2014-05-12 12:36:31]

Anyone knows why this is failing for iOS? Was it because missing
<(enable_autofill_dialog) variable?

I noticed that in gyp files in some cases, we check for
'enable_autofill_dialog==1 and OS!="android"' but in others we check for
'enable_autofill_dialog==1 and OS!="android" and OS!="ios"', is that difference
intentional?

[Jiang Jiang, 2014-05-13 13:27:53]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2014-05-13 13:28:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jiangj@opera.com/178193032/60001

[commit-bot: I haz the power, 2014-05-13 15:03:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-13 15:56:42]

Change committed as 270107