More rebaselines in fast for text selection color after VS2013

More rebaselines in fast for text selection color after VS2013

All text selection colour again.

TBR=dpranke@chromium.org
BUG=348800
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168432

[scottmg, 2014-03-05 05:09:56]

Committed patchset #1 manually as r168432 (presubmit successful).

[Dirk Pranke, 2014-03-05 20:47:27]

lgtm. Was the one linux baseline now redundant?

[scottmg, 2014-03-06 18:11:54]

On 2014/03/05 20:47:27, Dirk Pranke wrote:
> lgtm. Was the one linux baseline now redundant?

Hm, g-o-m did that to me a few times, but I'm not sure why.

I assumed it knew what it was doing, but I don't really understand how the
fallbacks work.

There's only a 'win' and 'mac' selection-gaps-at-fractional-offsets-expected.png
after this CL, so I guess that's broken?

[Dirk Pranke, 2014-03-06 18:28:00]

Linux falls back to windows, and g-o-m does attempt to optimize/de-dup
baselines, so it was probably doing the right thing. I wouldn't worry about it.

[scottmg, 2014-03-06 18:30:59]

[test-rebaselines]scottmg@scottmg:/work/cr/src$ ls -l
third_party/WebKit/LayoutTests/fast/sub-pixel/selection/
total 12
-rw-r----- 1 scottmg eng 2579 Nov 28 10:38
selection-gaps-at-fractional-offsets-expected.txt
-rw-r----- 1 scottmg eng 1264 Nov 28 10:38
selection-gaps-at-fractional-offsets.html
-rw-r----- 1 scottmg eng  717 Nov 28 10:38
selection-rect-in-sub-pixel-table.html
[test-rebaselines]scottmg@scottmg:/work/cr/src$ cat
third_party/WebKit/LayoutTests/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt
EDITING DELEGATE:
webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE:
webViewDidChangeSelection:WebViewDidChangeSelectionNotification
layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x295
  RenderBlock {HTML} at (0,0) size 800x295
    RenderBody {BODY} at (8,8) size 784x279
      RenderBlock {DIV} at (0,0) size 749x279 [border: (50px solid #FF0000)]
        RenderBlock {DIV} at (74.50,74.50) size 600x130
          RenderText {#text} at (0,0) size 600x130
            text run at (0,0) width 570: "Four score and seven years ago our
fathers brought forth,"
            text run at (570,0) width 10: " "
            text run at (0,10) width 600: "upon this continent, a new nation,
conceived in Liberty, and"
            text run at (600,10) width 0: " "
            text run at (0,20) width 600: "dedicated to the proposition that all
men are created equal."
            text run at (600,20) width 0: " "
            text run at (0,30) width 560: "Now we are engaged in a great civil
war, testing whether"
            text run at (560,30) width 10: " "
            text run at (0,40) width 590: "that nation, or any nation, so
conceived, and so dedicated,"
            text run at (590,40) width 10: " "
            text run at (0,50) width 580: "can long endure. We are met here on a
great battlefield of"
            text run at (580,50) width 10: " "
            text run at (0,60) width 550: "that war. We have come to dedicate a
portion of it as a"
            text run at (550,60) width 10: " "
            text run at (0,70) width 600: "final resting place for those who
here gave their lives that"
            text run at (600,70) width 0: " "
            text run at (0,80) width 590: "that nation might live. It is
altogether fitting and proper"
            text run at (590,80) width 10: " "
            text run at (0,90) width 580: "that we should do this. Four score
and seven years ago our"
            text run at (580,90) width 10: " "
            text run at (0,100) width 570: "fathers brought forth, upon this
continent, a new nation,"
            text run at (570,100) width 10: " "
            text run at (0,110) width 590: "conceived in Liberty, and dedicated
to the proposition that"
            text run at (590,110) width 10: " "
            text run at (0,120) width 260: "all men are created equal."
selection start: position 1 of child 0 {#text} of child 1 {DIV} of child 1 {DIV}
of body
selection end:   position 737 of child 0 {#text} of child 1 {DIV} of child 1
{DIV} of body
[test-rebaselines]scottmg@scottmg:/work/cr/src$
./webkit/tools/layout_tests/run_webkit_tests.py fast/sub-pixel/selection/Using
port 'linux-x86_64'
Test configuration: <lucid, x86_64, release>
View the test results at
file:///work/cr/src/webkit/Release/layout-test-results/results.html
Baseline search path: linux -> win -> generic
Using Release build
Pixel tests enabled
Regular timeout: 6000, slow test timeout: 30000
Command line: /work/cr/src/out/Release/content_shell --dump-render-tree
--enable-crash-reporter --crash-dumps-dir=/work/cr/src/out/Release/crash-dumps -

Found 2 tests; running 2, skipping 0.
                  
Running 1 content_shell.        

All 2 tests ran as expected.                                                   

[test-rebaselines]scottmg@scottmg:/work/cr/src$ 



So, did deleting that png mean it remove the pixel test part I guess?

[Dirk Pranke, 2014-03-06 18:37:46]

You can see the fallback path in the "Baseline search path" line in the
output.

Using the --details flag will tell you which baselines are actually getting
used:

% /src/bl/src/third_party/WebKit/Tools/Scripts/run-webkit-tests
--clobber-old-results --no-new-test-results --details
fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
Using port 'linux-x86_64'
Test configuration: <lucid, x86_64, release>
View the test results at
file:///src/bl/src/webkit/Release/layout-test-results/results.html
Baseline search path: linux -> win -> generic
Using Release build
Pixel tests enabled
Regular timeout: 6000, slow test timeout: 30000
Command line: /src/bl/src/out/Release/content_shell --dump-render-tree
--enable-crash-reporter
--crash-dumps-dir=/src/bl/src/out/Release/crash-dumps -

Found 1 test; running 1, skipping 0.

Running 1 content_shell.

[1/1] fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
  txt:
fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt
  png:
platform/win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png
  wav: <none>
  exp: PASS
  got: PASS
 took: 0.503

The test ran as expected.
%


On Thu, Mar 6, 2014 at 10:30 AM, <scottmg@chromium.org> wrote:

> [test-rebaselines]scottmg@scottmg:/work/cr/src$ ls -l
> third_party/WebKit/LayoutTests/fast/sub-pixel/selection/
> total 12
> -rw-r----- 1 scottmg eng 2579 Nov 28 10:38
> selection-gaps-at-fractional-offsets-expected.txt
> -rw-r----- 1 scottmg eng 1264 Nov 28 10:38
> selection-gaps-at-fractional-offsets.html
> -rw-r----- 1 scottmg eng  717 Nov 28 10:38
> selection-rect-in-sub-pixel-table.html
> [test-rebaselines]scottmg@scottmg:/work/cr/src$ cat
> third_party/WebKit/LayoutTests/fast/sub-pixel/selection/selection-gaps-at-
> fractional-offsets-expected.txt
> EDITING DELEGATE:
> webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> EDITING DELEGATE:
> webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> layer at (0,0) size 800x600
>   RenderView at (0,0) size 800x600
> layer at (0,0) size 800x295
>   RenderBlock {HTML} at (0,0) size 800x295
>     RenderBody {BODY} at (8,8) size 784x279
>       RenderBlock {DIV} at (0,0) size 749x279 [border: (50px solid
> #FF0000)]
>         RenderBlock {DIV} at (74.50,74.50) size 600x130
>           RenderText {#text} at (0,0) size 600x130
>             text run at (0,0) width 570: "Four score and seven years ago
> our
> fathers brought forth,"
>             text run at (570,0) width 10: " "
>             text run at (0,10) width 600: "upon this continent, a new
> nation,
> conceived in Liberty, and"
>             text run at (600,10) width 0: " "
>             text run at (0,20) width 600: "dedicated to the proposition
> that all
> men are created equal."
>             text run at (600,20) width 0: " "
>             text run at (0,30) width 560: "Now we are engaged in a great
> civil
> war, testing whether"
>             text run at (560,30) width 10: " "
>             text run at (0,40) width 590: "that nation, or any nation, so
> conceived, and so dedicated,"
>             text run at (590,40) width 10: " "
>             text run at (0,50) width 580: "can long endure. We are met
> here on a
> great battlefield of"
>             text run at (580,50) width 10: " "
>             text run at (0,60) width 550: "that war. We have come to
> dedicate a
> portion of it as a"
>             text run at (550,60) width 10: " "
>             text run at (0,70) width 600: "final resting place for those
> who
> here gave their lives that"
>             text run at (600,70) width 0: " "
>             text run at (0,80) width 590: "that nation might live. It is
> altogether fitting and proper"
>             text run at (590,80) width 10: " "
>             text run at (0,90) width 580: "that we should do this. Four
> score
> and seven years ago our"
>             text run at (580,90) width 10: " "
>             text run at (0,100) width 570: "fathers brought forth, upon
> this
> continent, a new nation,"
>             text run at (570,100) width 10: " "
>             text run at (0,110) width 590: "conceived in Liberty, and
> dedicated
> to the proposition that"
>             text run at (590,110) width 10: " "
>             text run at (0,120) width 260: "all men are created equal."
> selection start: position 1 of child 0 {#text} of child 1 {DIV} of child 1
> {DIV}
> of body
> selection end:   position 737 of child 0 {#text} of child 1 {DIV} of child
> 1
> {DIV} of body
> [test-rebaselines]scottmg@scottmg:/work/cr/src$
> ./webkit/tools/layout_tests/run_webkit_tests.py
> fast/sub-pixel/selection/Using
> port 'linux-x86_64'
> Test configuration: <lucid, x86_64, release>
> View the test results at
> file:///work/cr/src/webkit/Release/layout-test-results/results.html
> Baseline search path: linux -> win -> generic
> Using Release build
> Pixel tests enabled
> Regular timeout: 6000, slow test timeout: 30000
> Command line: /work/cr/src/out/Release/content_shell --dump-render-tree
> --enable-crash-reporter
--crash-dumps-dir=/work/cr/src/out/Release/crash-dumps
> -
>
> Found 2 tests; running 2, skipping 0.
>
> Running 1 content_shell.
>
> All 2 tests ran as expected.
>
> [test-rebaselines]scottmg@scottmg:/work/cr/src$
>
>
>
> So, did deleting that png mean it remove the pixel test part I guess?
>
>
> https://codereview.chromium.org/178193031/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[scottmg, 2014-03-06 18:43:35]

On 2014/03/06 18:37:46, Dirk Pranke wrote:
> You can see the fallback path in the "Baseline search path" line in the
> output.
> 
> Using the --details flag will tell you which baselines are actually getting
> used:
> 

Aha! Indeed, thanks.