Rename ProfileKeyedAPI to BrowserContextKeyedAPI and GetProfile to Get.

Rename ProfileKeyedAPI to BrowserContextKeyedAPI and GetProfile to Get.

Move it to extensions/browser. (Not extensions/browser/api, since it's now being used not just by API implementations.)

This change is purely mechanical (some lines are more affected by clang-format than others).

BUG=309909
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254999

[Yoyo Zhou, 2014-03-05 00:49:07]

jamescook: please review browser_context_keyed_api_factory.h and feel free to
skim the rest
sky: TBR for megarefactoring

[James Cook, 2014-03-05 02:33:29]

LGTM with nits for browser_context_keyed_api.h, the GYP files, and spot checks
of the rest.

Thanks for doing this.

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
File extensions/browser/browser_context_keyed_api_factory.h (right):

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:29: // These flags affect
what instance is returned when Get is called
optional nit: I sometimes say "Get()" when referring to a function.

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:55: //
GetFactoryInstance();
nit: Indent this like real code.  Or shorten the example to FooAPI to make it
fit.

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:76: static T*
Get(content::BrowserContext* context) {
Hooray!

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:87: //   void
BrowserContextKeyedAPIFactory<
Wow, that's an ugly line break. It's OK, but would calling it FooAPI make it
short enough to wrap well?

[Yoyo Zhou, 2014-03-05 02:51:28]

Thanks for the quick review.

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
File extensions/browser/browser_context_keyed_api_factory.h (right):

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:29: // These flags affect
what instance is returned when Get is called
On 2014/03/05 02:33:30, James Cook wrote:
> optional nit: I sometimes say "Get()" when referring to a function.

Done.

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:55: //
GetFactoryInstance();
On 2014/03/05 02:33:30, James Cook wrote:
> nit: Indent this like real code.  Or shorten the example to FooAPI to make it
> fit.

Changed to HistoryAPI to make it short enough.

https://codereview.chromium.org/178193030/diff/80001/extensions/browser/brows...
extensions/browser/browser_context_keyed_api_factory.h:87: //   void
BrowserContextKeyedAPIFactory<
On 2014/03/05 02:33:30, James Cook wrote:
> Wow, that's an ugly line break. It's OK, but would calling it FooAPI make it
> short enough to wrap well?

81 characters. *tears*

[Yoyo Zhou, 2014-03-05 02:51:55]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-03-05 02:52:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/178193030/100001

[commit-bot: I haz the power, 2014-03-05 10:21:07]

Change committed as 254999