Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 178193028: Print properly signed displacement in disassembler. (Closed)

Created:
6 years, 9 months ago by Michael Starzinger
Modified:
6 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Print properly signed displacement in disassembler. R=titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19667

Patch Set 1 #

Patch Set 2 : Port to x64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -51 lines) Patch
M src/ia32/disasm-ia32.cc View 1 2 chunks +14 lines, -10 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 2 chunks +20 lines, -27 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 3 chunks +13 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 7 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
This is a followup to https://codereview.chromium.org/176993004/ which fixes printing for all operand types, ports it ...
6 years, 9 months ago (2014-03-04 18:29:03 UTC) #1
titzer
lgtm
6 years, 9 months ago (2014-03-05 08:43:08 UTC) #2
Michael Starzinger
6 years, 9 months ago (2014-03-05 09:28:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19667 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698