Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/lithium.cc

Issue 178193026: Deoptimization fix for HPushArgument. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 zone()); 491 zone());
492 int argument_index = *argument_index_accumulator; 492 int argument_index = *argument_index_accumulator;
493 493
494 // Store the environment description into the environment 494 // Store the environment description into the environment
495 // (with holes for nested objects) 495 // (with holes for nested objects)
496 for (int i = 0; i < hydrogen_env->length(); ++i) { 496 for (int i = 0; i < hydrogen_env->length(); ++i) {
497 if (hydrogen_env->is_special_index(i)) continue; 497 if (hydrogen_env->is_special_index(i)) continue;
498 498
499 LOperand* op; 499 LOperand* op;
500 HValue* value = hydrogen_env->values()->at(i); 500 HValue* value = hydrogen_env->values()->at(i);
501 CHECK(!value->IsPushArgument()); // Do not deopt outgoing arguments
501 if (value->IsArgumentsObject() || value->IsCapturedObject()) { 502 if (value->IsArgumentsObject() || value->IsCapturedObject()) {
502 op = LEnvironment::materialization_marker(); 503 op = LEnvironment::materialization_marker();
503 } else if (value->IsPushArgument()) {
504 op = new(zone()) LArgument(argument_index++);
505 } else { 504 } else {
506 op = UseAny(value); 505 op = UseAny(value);
507 } 506 }
508 result->AddValue(op, 507 result->AddValue(op,
509 value->representation(), 508 value->representation(),
510 value->CheckFlag(HInstruction::kUint32)); 509 value->CheckFlag(HInstruction::kUint32));
511 } 510 }
512 511
513 // Recursively store the nested objects into the environment 512 // Recursively store the nested objects into the environment
514 for (int i = 0; i < hydrogen_env->length(); ++i) { 513 for (int i = 0; i < hydrogen_env->length(); ++i) {
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 607
609 608
610 LPhase::~LPhase() { 609 LPhase::~LPhase() {
611 if (ShouldProduceTraceOutput()) { 610 if (ShouldProduceTraceOutput()) {
612 isolate()->GetHTracer()->TraceLithium(name(), chunk_); 611 isolate()->GetHTracer()->TraceLithium(name(), chunk_);
613 } 612 }
614 } 613 }
615 614
616 615
617 } } // namespace v8::internal 616 } } // namespace v8::internal
OLDNEW
« src/lithium.h ('K') | « src/lithium.h ('k') | src/lithium-allocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698