Deoptimization fix for HPushArgument.

Deoptimization fix for HPushArgument.

HPushArgument should never be used in a simulation environment
because the slot addresses for the arguments can be off (e.g.,
due to on-stack arguments object of an inlined caller).

R=mstarzinger@chromium.org
BUG=v8:3183
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=19675

[Michael Starzinger, 2014-03-04 15:40:12]

Looking good, I like it, just one more thing.

https://codereview.chromium.org/178193026/diff/1/src/lithium.h
File src/lithium.h (right):

https://codereview.chromium.org/178193026/diff/1/src/lithium.h#newcode56
src/lithium.h:56: ARGUMENT
The "ARGUMENT" kind should be obsolete now.

https://codereview.chromium.org/178193026/diff/1/src/lithium.h#newcode66
src/lithium.h:66: LITHIUM_OPERAND_PREDICATE(Argument, ARGUMENT)
Likewise.

[Michael Starzinger, 2014-03-04 15:42:14]

LGTM (once previous comment is addressed).

[Jarin, 2014-03-05 08:30:14]

Good catch, thanks! This caused more deletions, so I have uploaded the new
version.

https://codereview.chromium.org/178193026/diff/1/src/lithium.h
File src/lithium.h (right):

https://codereview.chromium.org/178193026/diff/1/src/lithium.h#newcode56
src/lithium.h:56: ARGUMENT
On 2014/03/04 15:40:12, Michael Starzinger wrote:
> The "ARGUMENT" kind should be obsolete now.

Done.

https://codereview.chromium.org/178193026/diff/1/src/lithium.h#newcode66
src/lithium.h:66: LITHIUM_OPERAND_PREDICATE(Argument, ARGUMENT)
On 2014/03/04 15:40:12, Michael Starzinger wrote:
> Likewise.

Done.

[Michael Starzinger, 2014-03-05 09:03:05]

Still LGTM.

[Jarin, 2014-03-05 12:45:57]

Committed patchset #2 manually as r19675 (tree was closed).