Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 178193008: chmod +x 7z.dll and 7z.exe for cygwin (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
iannucci, Peter Kasting
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A win_toolchain/7z/7z.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A win_toolchain/7z/7z.exe View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
Hopefully this handles both svn and git, I'm not exactly sure how these sort of ...
6 years, 9 months ago (2014-02-28 04:53:26 UTC) #1
scottmg
Committed patchset #1 manually as r254042 (presubmit successful).
6 years, 9 months ago (2014-02-28 04:53:58 UTC) #2
Peter Kasting
On 2014/02/28 04:53:26, scottmg wrote: > Hopefully this handles both svn and git, I'm not ...
6 years, 9 months ago (2014-02-28 04:54:16 UTC) #3
scottmg
On 2014/02/28 04:54:16, Peter Kasting wrote: > On 2014/02/28 04:53:26, scottmg wrote: > > Hopefully ...
6 years, 9 months ago (2014-02-28 04:55:02 UTC) #4
iannucci
6 years, 9 months ago (2014-02-28 08:36:08 UTC) #5
Message was sent while issue was closed.
On 2014/02/28 04:55:02, scottmg wrote:
> On 2014/02/28 04:54:16, Peter Kasting wrote:
> > On 2014/02/28 04:53:26, scottmg wrote:
> > > Hopefully this handles both svn and git, I'm not exactly sure how these
sort
> > of
> > > things are propagated between them.
> > 
> > This looks weird... the files are showing up as added instead of modified?
> 
> Yeah, I'm not sure why. In
> https://codereview.chromium.org/178193008/patch/1/10001 there's just a mode
> change though.

Raw patch lgtm... Rietveld is just being its weird old self again.

Powered by Google App Engine
This is Rietveld 408576698