Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1781923002: Revert of Transfer media::VideoFrame using mojo shared memory (Closed)

Created:
4 years, 9 months ago by tsergeant
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Transfer media::VideoFrame using mojo shared memory (patchset #4 id:60001 of https://codereview.chromium.org/1769673002/ ) Reason for revert: media_type_converters.cc is failing to compile on Win X64 GN. See: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/11580 https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19350 Original issue's description: > Transfer media::VideoFrame using mojo shared memory > > Now that MojoSharedBufferVideoFrame exists and uses mojo shared memory, > pass the shared memory handle when passing using mojo. TypeConverter > for this interface updated to handle the shared memory. > > BUG=510088 > TEST=update media_mojo_unittests pass > > Committed: https://crrev.com/5e18b5d78b3bf914052759d5ab3bd39778f0bceb > Cr-Commit-Position: refs/heads/master@{#380200} TBR=rockot@chromium.org,xhwang@chromium.org,jrummell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510088 Committed: https://crrev.com/044355b27f57075d21ef68442cd397f31366dc80 Cr-Commit-Position: refs/heads/master@{#380275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -168 lines) Patch
M media/mojo/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/common/media_type_converters.cc View 4 chunks +84 lines, -37 lines 0 comments Download
M media/mojo/common/media_type_converters_unittest.cc View 4 chunks +25 lines, -85 lines 0 comments Download
M media/mojo/common/mojo_shared_buffer_video_frame.h View 3 chunks +0 lines, -24 lines 0 comments Download
M media/mojo/common/mojo_shared_buffer_video_frame.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tsergeant
Created Revert of Transfer media::VideoFrame using mojo shared memory
4 years, 9 months ago (2016-03-10 00:48:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781923002/1
4 years, 9 months ago (2016-03-10 00:48:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 00:49:32 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 00:50:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/044355b27f57075d21ef68442cd397f31366dc80
Cr-Commit-Position: refs/heads/master@{#380275}

Powered by Google App Engine
This is Rietveld 408576698