Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: sdk/lib/io/http.dart

Issue 17819004: Document HttpClientResponse data. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http.dart
diff --git a/sdk/lib/io/http.dart b/sdk/lib/io/http.dart
index b045c11f1fff6e808680c25d0bda6a1b7c6160ff..5d813f9d58b13181cd05c33de80355f0037f18e9 100644
--- a/sdk/lib/io/http.dart
+++ b/sdk/lib/io/http.dart
@@ -845,6 +845,8 @@ abstract class HttpResponse implements IOSink {
*
* When the HTTP response is ready a [HttpClientResponse] object is
* provided which provides access to the headers and body of the response.
Søren Gjesse 2013/06/26 08:08:01 Add some additional information here that the body
Anders Johnsen 2013/06/26 08:40:13 Done.
+ * If a body is present, it must be read. Otherwise, it'll lead to a resource
+ * leak. Consider using [HttpClientResponse.drain] if the body is unused.
Søren Gjesse 2013/06/26 08:08:01 a resource leak -> resource leaks
Anders Johnsen 2013/06/26 08:40:13 Done.
*
* HttpClient client = new HttpClient();
* client.getUrl(Uri.parse("http://www.example.com/"))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698