Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 17819003: Extract StackFrameIteratorBase (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Extract StackFrameIteratorBase This change introduces StackFrameIteratorBase which owns singleton frame instances and encapsulates some basic iterator functionality. It has two actual implementations: StackFrameIterator and SafeStackFrameIterator. All logic specific to frame iteration at a random point (basically checks that fp and sp extracted from stack frames are within current stack boundaries) used only by CPU profiler is now concentrated in SafeStackFrameIterator. Generic stack iteration used in all other places is put into StackFrameIterator. Also this iterator unlike SafeStackFrameIterator iterates through stack handlers. StackAddressValidator and ExitFrameValidator classes were removed in favor of inline checks and simple methods. BUG=None R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15349

Patch Set 1 #

Patch Set 2 : Removed temporarty class #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -206 lines) Patch
M src/frames.h View 1 2 21 chunks +59 lines, -95 lines 0 comments Download
M src/frames.cc View 1 2 3 8 chunks +77 lines, -91 lines 0 comments Download
M src/frames-inl.h View 1 2 5 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 6 months ago (2013-06-26 09:26:29 UTC) #1
loislo
lgtm
7 years, 6 months ago (2013-06-26 12:34:11 UTC) #2
Sven Panne
lgtm
7 years, 5 months ago (2013-06-27 09:29:06 UTC) #3
yurys
7 years, 5 months ago (2013-06-27 09:34:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r15349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698