Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Issue 1781853002: Revert of Create explicit microhttpd.gyp (Closed)

Created:
4 years, 9 months ago by joshualitt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create explicit microhttpd.gyp (patchset #6 id:100001 of https://codereview.chromium.org/1779903002/ ) Reason for revert: breaking per commit housekeeper Original issue's description: > Create explicit microhttpd.gyp > > Committed: https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8 TBR=bungeman@google.com,jcgregorio@google.com,ethannicholas@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f842c50116863f44240f806509f14e434eabb0a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -186 lines) Patch
M gyp/common_variables.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/microhttpd.gyp View 1 chunk +38 lines, -175 lines 0 comments Download
M gyp/most.gyp View 2 chunks +6 lines, -4 lines 0 comments Download
D third_party/libmicrohttpd/MHD_config.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
joshualitt
Created Revert of Create explicit microhttpd.gyp
4 years, 9 months ago (2016-03-09 22:26:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781853002/1
4 years, 9 months ago (2016-03-09 22:26:12 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:26:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f842c50116863f44240f806509f14e434eabb0a8

Powered by Google App Engine
This is Rietveld 408576698