Remove CallbackParamTraits and CallbackForward

Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554299
Committed: https://crrev.com/d2046ce34fb73579ea79834a85228c0cb87a49f6
Cr-Commit-Position: refs/heads/master@{#387435}

[tzik, 2016-03-10 06:49:36]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 06:49:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781843003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781843003/1

[tzik, 2016-03-10 07:11:17]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 07:11:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781843003/20001

[commit-bot: I haz the power, 2016-03-10 08:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 08:11:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-03-10 08:54:46]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 08:54:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781843003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781843003/60001

[commit-bot: I haz the power, 2016-03-10 10:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 10:52:36]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-03-10 11:40:04]

Description was changed from

==========
Remove CallbackParamTraits

BUG=
==========

to

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554298
==========

[tzik, 2016-03-10 11:40:04]

tzik@chromium.org changed reviewers:
+ thakis@chromium.org

[tzik, 2016-03-10 11:40:35]

Description was changed from

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554298
==========

to

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554299
==========

[tzik, 2016-03-10 12:18:56]

PTAL

[Nico, 2016-03-10 21:54:50]

https://codereview.chromium.org/1781843003/diff/60001/base/callback_internal.h
File base/callback_internal.h (left):

https://codereview.chromium.org/1781843003/diff/60001/base/callback_internal....
base/callback_internal.h:232: typename std::enable_if<!IsMoveOnlyType<T>::value,
T>::type& CallbackForward(
Don't we lose this protection now? Or does std::foward() have this too?

[tzik, 2016-03-14 08:49:42]

https://codereview.chromium.org/1781843003/diff/60001/base/callback_internal.h
File base/callback_internal.h (left):

https://codereview.chromium.org/1781843003/diff/60001/base/callback_internal....
base/callback_internal.h:232: typename std::enable_if<!IsMoveOnlyType<T>::value,
T>::type& CallbackForward(
On 2016/03/10 21:54:50, Nico wrote:
> Don't we lose this protection now? Or does std::foward() have this too?

Do you mean a protection to prevent moving non-move-only type?
Yes, we'll lose it. We'll no longer check if the type is move-only. std::forward
doesn't check if it's movable. I think it was just needed to do forwarding
without rvalue reference, but no longer needed.

[Nico, 2016-04-14 18:25:14]

lgtm

Sorry, dropped the ball on this

[tzik, 2016-04-14 20:01:26]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-04-14 20:02:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781843003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781843003/60001

[commit-bot: I haz the power, 2016-04-14 21:44:48]

Description was changed from

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554299
==========

to

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554299
==========

[commit-bot: I haz the power, 2016-04-14 21:44:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-14 21:48:17]

Description was changed from

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554299
==========

to

==========
Remove CallbackParamTraits and CallbackForward

They are no longer used by Callback stuff and we can replace other usage
of them with Universal References and std::forward.
This CL removes their impl and updates the use-site.

BUG=554299

Committed: https://crrev.com/d2046ce34fb73579ea79834a85228c0cb87a49f6
Cr-Commit-Position: refs/heads/master@{#387435}
==========

[commit-bot: I haz the power, 2016-04-14 21:48:18]

Patchset 4 (id:??) landed as
https://crrev.com/d2046ce34fb73579ea79834a85228c0cb87a49f6
Cr-Commit-Position: refs/heads/master@{#387435}