Add LogoutConfirmationController to show LogoutConfirmationDialogs

ash/system/logout_button/logout_button_tray.cc

Index: ash/system/logout_button/logout_button_tray.cc
diff --git a/ash/system/logout_button/logout_button_tray.cc b/ash/system/logout_button/logout_button_tray.cc
index aaa00392b201711315a24dc0c448ec9916ff8335..3afc8df6d14188729ac44fd4f4168a65070698ee 100644
--- a/ash/system/logout_button/logout_button_tray.cc
+++ b/ash/system/logout_button/logout_button_tray.cc
@@ -6,12 +6,14 @@
 
 #include "ash/shelf/shelf_types.h"
 #include "ash/shell.h"
+#include "ash/system/logout_confirmation/logout_confirmation_controller.h"
 #include "ash/system/status_area_widget.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/system_tray_notifier.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_utils.h"
 #include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
 #include "grit/ash_resources.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/events/event.h"
@@ -62,21 +64,6 @@ class LogoutButton : public views::LabelButton {
   DISALLOW_COPY_AND_ASSIGN(LogoutButton);
 };
 
-class LogoutConfirmationDialogDelegate
-    : public LogoutConfirmationDialogView::Delegate {
-
- public:
-  LogoutConfirmationDialogDelegate() {}
-  virtual ~LogoutConfirmationDialogDelegate() {}
-
-  virtual void LogoutCurrentUser() OVERRIDE;
-  virtual base::TimeTicks GetCurrentTime() const OVERRIDE;
-  virtual void ShowDialog(views::DialogDelegate* dialog) OVERRIDE;
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(LogoutConfirmationDialogDelegate);
-};
-
 }  // namespace
 
 LogoutButton::LogoutButton(views::ButtonListener* listener)
@@ -107,62 +94,20 @@ LogoutButton::LogoutButton(views::ButtonListener* listener)
 LogoutButton::~LogoutButton() {
 }
 
-void LogoutConfirmationDialogDelegate::LogoutCurrentUser() {
-  Shell::GetInstance()->system_tray_delegate()->SignOut();
-}
-
-base::TimeTicks LogoutConfirmationDialogDelegate::GetCurrentTime() const {
-  return base::TimeTicks::Now();
-}
-
-void LogoutConfirmationDialogDelegate::ShowDialog(
-    views::DialogDelegate *dialog) {
-  views::DialogDelegate::CreateDialogWidget(
-      dialog, ash::Shell::GetPrimaryRootWindow(), NULL);
-  dialog->GetWidget()->Show();
-}
-
 LogoutButtonTray::LogoutButtonTray(StatusAreaWidget* status_area_widget)
     : TrayBackgroundView(status_area_widget),
       button_(NULL),
       login_status_(user::LOGGED_IN_NONE),
-      show_logout_button_in_tray_(false),
-      confirmation_dialog_(NULL),
-      confirmation_delegate_(new LogoutConfirmationDialogDelegate) {
+      show_logout_button_in_tray_(false) {
   button_ = new LogoutButton(this);
   tray_container()->AddChildView(button_);
   tray_container()->SetBorder(views::Border::NullBorder());
-  // The Shell may not exist in some unit tests.
-  if (Shell::HasInstance()) {
-    Shell::GetInstance()->system_tray_notifier()->
-        AddLogoutButtonObserver(this);
-  }
+  Shell::GetInstance()->system_tray_notifier()->AddLogoutButtonObserver(this);
 }
 
 LogoutButtonTray::~LogoutButtonTray() {
-  EnsureConfirmationDialogIsClosed();
-  // The Shell may not exist in some unit tests.
-  if (Shell::HasInstance()) {
-    Shell::GetInstance()->system_tray_notifier()->
-        RemoveLogoutButtonObserver(this);
-  }
-}
-
-bool LogoutButtonTray::IsConfirmationDialogShowing() const {
-  return confirmation_dialog_ != NULL;
-}
-
-void LogoutButtonTray::EnsureConfirmationDialogIsShowing() {
-  if (!confirmation_dialog_) {
-    confirmation_dialog_ = new LogoutConfirmationDialogView(
-        this, confirmation_delegate_.get());
-    confirmation_dialog_->Show(dialog_duration_);
-  }
-}
-
-void LogoutButtonTray::EnsureConfirmationDialogIsClosed() {
-  if (confirmation_dialog_)
-    confirmation_dialog_->Close();
+  Shell::GetInstance()->system_tray_notifier()->
+      RemoveLogoutButtonObserver(this);
 }
 
 void LogoutButtonTray::SetShelfAlignment(ShelfAlignment alignment) {
@@ -189,18 +134,18 @@ void LogoutButtonTray::OnShowLogoutButtonInTrayChanged(bool show) {
 
 void LogoutButtonTray::OnLogoutDialogDurationChanged(base::TimeDelta duration) {
   dialog_duration_ = duration;
-  if (confirmation_dialog_)
-    confirmation_dialog_->UpdateDialogDuration(dialog_duration_);
 }
 
 void LogoutButtonTray::ButtonPressed(views::Button* sender,
                                      const ui::Event& event) {
   DCHECK_EQ(sender, button_);
-  // Sign out immediately if |dialog_duration_| is non-positive.
-  if (dialog_duration_ <= base::TimeDelta())
-    confirmation_delegate_->LogoutCurrentUser();
-  else
-    EnsureConfirmationDialogIsShowing();
+  if (dialog_duration_ <= base::TimeDelta()) {
+    // Sign out immediately if |dialog_duration_| is non-positive.
+    Shell::GetInstance()->system_tray_delegate()->SignOut();
+  } else {
+    Shell::GetInstance()->logout_confirmation_controller()->ConfirmLogout(
+        base::TimeTicks::Now() + dialog_duration_);

[stevenjb, 2014/02/27 17:58:44]

Is there an edge case here where the tray can outlive the controller? (i.e. I
think we may need a test here).

[bartfab (slow), 2014/02/28 12:13:49]

The controller is destroyed in the Shell's destructor. Even if a tray was still
alive, it would no longer reach the ButttonPressed() method for lack of input
events. But it is easy to add a check to be on the safe side. Done.

+  }
 }
 
 void LogoutButtonTray::UpdateAfterLoginStatusChange(
@@ -213,21 +158,10 @@ void LogoutButtonTray::UpdateAfterLoginStatusChange(
   UpdateVisibility();
 }
 
-void LogoutButtonTray::ReleaseConfirmationDialog() {
-  confirmation_dialog_ = NULL;
-}
-
-void LogoutButtonTray::SetDelegateForTest(
-    scoped_ptr<LogoutConfirmationDialogView::Delegate> delegate) {
-  confirmation_delegate_ = delegate.Pass();
-}
-
 void LogoutButtonTray::UpdateVisibility() {
   SetVisible(show_logout_button_in_tray_ &&
              login_status_ != user::LOGGED_IN_NONE &&
              login_status_ != user::LOGGED_IN_LOCKED);
-  if (!show_logout_button_in_tray_)
-    EnsureConfirmationDialogIsClosed();
 }
 
 }  // namespace internal