Add LogoutConfirmationController to show LogoutConfirmationDialogs

ash/system/logout_confirmation/logout_confirmation_controller.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SYSTEM_LOGOUT_CONFIRMATION_LOGOUT_CONFIRMATION_CONTROLLER_H_
+#define ASH_SYSTEM_LOGOUT_CONFIRMATION_LOGOUT_CONFIRMATION_CONTROLLER_H_
+
+#include "ash/ash_export.h"
+#include "base/basictypes.h"
+#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/time/time.h"
+#include "base/timer/timer.h"
+
+namespace base {
+class TickClock;
+}
+
+namespace ash {
+namespace internal {
+
+class LogoutConfirmationDialog;
+
+// This class shows a dialog asking the user to confirm or deny logout and
+// terminates the session if the user either confirms or allows the countdown
+// shown in the dialog to expire.
+// It is guaranteed that no more than one confirmation dialog will be visible at
+// any given time. If there are multiple requests to show a confirmation dialog
+// at the same time, the dialog whose countdown expires first is shown.
+class ASH_EXPORT LogoutConfirmationController {
+ public:
+  LogoutConfirmationController(scoped_ptr<base::TickClock> clock,

[stevenjb, 2014/02/27 17:58:44]

Are we passing in clock (instead of constructing it) just for tests? If so, I
think it would be more clear to add a SetClockForTest() method that resets
clock_ instead.

[bartfab (slow), 2014/02/28 12:13:49]

Done.

+                               const base::Closure& logout_closure);
+  virtual ~LogoutConfirmationController();

[stevenjb, 2014/02/27 17:58:44]

This doesn't appear to need to be virtual.

[bartfab (slow), 2014/02/28 12:13:49]

You were right in the version of the CL you looked at. The class now inherits
from ShellObserver though so that the virtual is warranted :).

+
+  base::TickClock* Clock() const;

[stevenjb, 2014/02/27 17:58:44]

This can be:
  base::TickClock* clock() const { return clock_.get(); }

[bartfab (slow), 2014/02/28 12:13:49]

Done.

+
+  // Shows a LogoutConfirmationDialog. If a confirmation dialog is already being
+  // shown, it is closed and a new one opened if |logout_time| is earlier than
+  // the current dialog's |logout_time_|.
+  void ConfirmLogout(base::TimeTicks logout_time);
+
+  // Called by the |dialog_| when the user confirms logout.
+  void OnLogoutConfirmed();

[stevenjb, 2014/02/27 17:58:44]

WS

[bartfab (slow), 2014/02/28 12:13:49]

Done.

+  // Called by the |dialog_| when it is closed.
+  void OnDialogClosed();
+
+ private:
+  scoped_ptr<base::TickClock> clock_;
+  base::Closure logout_closure_;
+
+  base::TimeTicks logout_time_;
+  LogoutConfirmationDialog* dialog_;

[stevenjb, 2014/02/27 17:58:44]

Comment ownership of raw pointer. (Views hierarchy I assume?)

[bartfab (slow), 2014/02/28 12:13:49]

Done.

+  base::Timer logout_timer_;
+
+  DISALLOW_COPY_AND_ASSIGN(LogoutConfirmationController);
+};
+
+}  // namespace internal
+}  // namespace ash
+
+#endif  // ASH_SYSTEM_LOGOUT_CONFIRMATION_LOGOUT_CONFIRMATION_CONTROLLER_H_