Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 1781753002: Fix bug with http URL color in location bar (Mac). (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug with http URL color in location bar (Mac). This is a fix for a regression introduced in the recent Material Design toolbar changes. BUG=593379 Committed: https://crrev.com/5a0b22c0cb636e508e54e88204eba1ec1e084a60 Cr-Commit-Position: refs/heads/master@{#380188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shrike
PTAL
4 years, 9 months ago (2016-03-09 19:08:48 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-09 19:15:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1781753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1781753002/1
4 years, 9 months ago (2016-03-09 19:16:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 20:06:51 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:09:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a0b22c0cb636e508e54e88204eba1ec1e084a60
Cr-Commit-Position: refs/heads/master@{#380188}

Powered by Google App Engine
This is Rietveld 408576698