Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1781703002: Change bleeding-edge version to 1.16.0, merge stable and bleeding-edge changelog. (Closed)

Created:
4 years, 9 months ago by Bill Hesse
Modified:
4 years, 9 months ago
Reviewers:
mit, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change bleeding-edge version to 1.16.0, merge stable and bleeding-edge changelog. BUG= R=kevmoo@google.com, mit@google.com Committed: https://github.com/dart-lang/sdk/commit/00e6b92e2099ad2055a857020add7837c903874d

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebase changelog changes. #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M CHANGELOG.md View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M tools/VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Bill Hesse
TBR=mit@google.com
4 years, 9 months ago (2016-03-09 17:55:13 UTC) #2
Bill Hesse
4 years, 9 months ago (2016-03-09 17:57:01 UTC) #4
mit
lgtm, added a few cosmetic comments https://codereview.chromium.org/1781703002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1781703002/diff/1/CHANGELOG.md#newcode79 CHANGELOG.md:79: * `dart:io`: Fix ...
4 years, 9 months ago (2016-03-09 18:03:14 UTC) #6
kevmoo
LGTM - ditto to mit@'s comments
4 years, 9 months ago (2016-03-09 18:04:02 UTC) #7
Bill Hesse
https://codereview.chromium.org/1781703002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1781703002/diff/1/CHANGELOG.md#newcode76 CHANGELOG.md:76: * VM: Fixes a code generation bug on x64. ...
4 years, 9 months ago (2016-03-09 18:08:08 UTC) #8
Bill Hesse
4 years, 9 months ago (2016-03-09 18:14:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
00e6b92e2099ad2055a857020add7837c903874d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698