Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 1781683002: Fix clang-cl build for pdf_enable_xfa=1 (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M xfa/src/fgas/src/localization/fx_datetime.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Oliver Chang
Tom, for review.
4 years, 9 months ago (2016-03-09 17:44:54 UTC) #1
Oliver Chang
Tom, for review.
4 years, 9 months ago (2016-03-09 17:44:55 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-09 17:49:07 UTC) #3
Oliver Chang
4 years, 9 months ago (2016-03-09 17:50:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c76831bb60d3c938b82a64a45f6b2af5b5f24bed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698